fix(compiler-cli): support qualified names in typeof type references

JoostK · crisbeto · commit 778460fccac1 · 2026-01-02T08:21:12.000+01:00
This commit expands the static interpreter to now understand qualified names in `typeof` type queries. Fixes #65686 (cherry picked from commit f12e160)
diff --git a/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts b/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts
@@ -734,13 +734,14 @@ export class StaticInterpreter {
   }
 
   private visitTypeQuery(node: ts.TypeQueryNode, context: Context): ResolvedValue {
-    if (!ts.isIdentifier(node.exprName)) {
+    const exprName = ts.isQualifiedName(node.exprName) ? node.exprName.right : node.exprName;
+    if (!ts.isIdentifier(exprName)) {
       return DynamicValue.fromUnknown(node);
     }
 
-    const decl = this.host.getDeclarationOfIdentifier(node.exprName);
+    const decl = this.host.getDeclarationOfIdentifier(exprName);
     if (decl === null) {
-      return DynamicValue.fromUnknownIdentifier(node.exprName);
+      return DynamicValue.fromUnknownIdentifier(exprName);
     }
 
     const declContext: Context = {...context, ...joinModuleContext(context, node, decl)};
diff --git a/packages/compiler-cli/src/ngtsc/partial_evaluator/test/evaluator_spec.ts b/packages/compiler-cli/src/ngtsc/partial_evaluator/test/evaluator_spec.ts
@@ -425,6 +425,33 @@ runInEachFileSystem(() => {
       expect(local.ownedByModuleGuess).toBeNull();
     });
 
+    // https://github.com/angular/angular/issues/65686
+    it('supports declarations of readonly tuples with class references using qualified names', () => {
+      const tuple = evaluate(
+        `
+        import * as ext from 'external';
+        declare class Local {}
+        declare const x: readonly [typeof ext.External];`,
+        `x`,
+        [
+          {
+            name: _('/node_modules/external/index.d.ts'),
+            contents: 'export declare class External {}',
+          },
+        ],
+      );
+      if (!Array.isArray(tuple)) {
+        return fail('Should have evaluated tuple as an array');
+      }
+      const [external] = tuple;
+      if (!(external instanceof Reference)) {
+        return fail('Should have evaluated `typeof ext.External` to a Reference');
+      }
+      expect(ts.isClassDeclaration(external.node)).toBe(true);
+      expect(external.debugName).toBe('External');
+      expect(external.ownedByModuleGuess).toBe('external');
+    });
+
     it('evaluates tuple elements it cannot understand to DynamicValue', () => {
       const value = evaluate(`declare const x: ['foo', string];`, `x`) as [string, DynamicValue];
 

Original file line number	Diff line number	Diff line change
`@@ -734,13 +734,14 @@ export class StaticInterpreter {`
`734`	`734`	`}`
`735`	`735`
`736`	`736`	`private visitTypeQuery(node: ts.TypeQueryNode, context: Context): ResolvedValue {`
`737`		`- if (!ts.isIdentifier(node.exprName)) {`
	`737`	`+ const exprName = ts.isQualifiedName(node.exprName) ? node.exprName.right : node.exprName;`
	`738`	`+ if (!ts.isIdentifier(exprName)) {`
`738`	`739`	`return DynamicValue.fromUnknown(node);`
`739`	`740`	`}`
`740`	`741`
`741`		`- const decl = this.host.getDeclarationOfIdentifier(node.exprName);`
	`742`	`+ const decl = this.host.getDeclarationOfIdentifier(exprName);`
`742`	`743`	`if (decl === null) {`
`743`		`- return DynamicValue.fromUnknownIdentifier(node.exprName);`
	`744`	`+ return DynamicValue.fromUnknownIdentifier(exprName);`
`744`	`745`	`}`
`745`	`746`
`746`	`747`	`const declContext: Context = {...context, ...joinModuleContext(context, node, decl)};`