Skip to content

Commit 775f918

Browse files
josephperrottthePunderWoman
authored andcommitted
build: remove usages of rules_nodejs (#62885)
Remove rules_nodejs usages with direct migrations to rule_js alternatives PR Close #62885
1 parent de37d1a commit 775f918

File tree

60 files changed

+58
-122
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+58
-122
lines changed

BUILD.bazel

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
load("@aspect_bazel_lib//lib:copy_to_bin.bzl", "copy_to_bin")
21
load("@aspect_rules_js//js:defs.bzl", "js_library")
32
load("@npm2//:defs.bzl", "npm_link_all_packages")
43
load("//:yarn.bzl", "YARN_PATH")
5-
load("//tools:defaults2.bzl", "js_binary")
4+
load("//tools:defaults2.bzl", "copy_to_bin", "js_binary")
65

76
package(default_visibility = ["//visibility:public"])
87

adev/shared-docs/defaults.bzl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
load("@aspect_bazel_lib//lib:copy_to_bin.bzl", _copy_to_bin = "copy_to_bin")
22
load("@aspect_bazel_lib//lib:copy_to_directory.bzl", _copy_to_directory = "copy_to_directory")
33
load("@aspect_rules_esbuild//esbuild:defs.bzl", _esbuild = "esbuild")
4-
load("@aspect_rules_js//js:defs.bzl", _js_binary = "js_binary", _js_library = "js_library", _js_run_binary = "js_run_binary")
54
load("@devinfra//bazel/private:path_relative_to_label.bzl", _path_relative_to_label = "path_relative_to_label")
65
load(
76
"//tools:defaults2.bzl",
87
_jasmine_test = "jasmine_test",
8+
_js_binary = "js_binary",
9+
_js_library = "js_library",
10+
_js_run_binary = "js_run_binary",
911
_ng_package = "ng_package",
1012
_ng_project = "ng_project",
1113
_sass_binary = "sass_binary",

adev/shared-docs/pipeline/api-gen/extraction/extract_api_to_json.bzl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ def _extract_api_to_json(ctx):
3131
args.add(json_output.path)
3232

3333
# Pass the import path map
34-
# TODO: consider module_mappings_aspect to deal with path mappings instead of manually
35-
# specifying them
36-
# https://github.com/bazelbuild/rules_nodejs/blob/5.x/internal/linker/link_node_modules.bzl#L236
3734
path_map = {}
3835
for target, path in ctx.attr.import_map.items():
3936
files = target.files.to_list()

adev/src/assets/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@aspect_bazel_lib//lib:copy_to_directory.bzl", "copy_to_directory")
1+
load("//adev/shared-docs:defaults.bzl", "copy_to_directory")
22
load("//adev/shared-docs/pipeline/api-gen/manifest:generate_api_manifest.bzl", "generate_api_manifest")
33

44
package(default_visibility = ["//adev:__subpackages__"])

adev/src/assets/icons/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@aspect_bazel_lib//lib:copy_to_bin.bzl", "copy_to_bin")
1+
load("//adev/shared-docs:defaults.bzl", "copy_to_bin")
22

33
exports_files(
44
glob(["*"]),

adev/src/assets/images/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@aspect_bazel_lib//lib:copy_to_bin.bzl", "copy_to_bin")
1+
load("//adev/shared-docs:defaults.bzl", "copy_to_bin")
22

33
exports_files(
44
glob(["*"]),

adev/src/assets/others/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@aspect_bazel_lib//lib:copy_to_bin.bzl", "copy_to_bin")
1+
load("//adev/shared-docs:defaults.bzl", "copy_to_bin")
22

33
exports_files(
44
glob(["*"]),

adev/src/content/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
1+
load("//adev/shared-docs:defaults.bzl", "js_library")
22
load("//adev/shared-docs:index.bzl", "generate_guides")
33

44
generate_guides(

adev/src/content/best-practices/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
1+
load("//adev/shared-docs:defaults.bzl", "js_library")
22
load("//adev/shared-docs:index.bzl", "generate_guides")
33

44
generate_guides(

adev/src/content/ecosystem/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
1+
load("//adev/shared-docs:defaults.bzl", "js_library")
22
load("//adev/shared-docs:index.bzl", "generate_guides")
33

44
generate_guides(

0 commit comments

Comments
 (0)