refactor(migrations): ensure control flow analysis of signal input migration works with all TS versions (#57566)

devversion · AndrewKushnir · commit 6e28f96d5fc6 · 2024-08-29T07:51:38.000-07:00
Ensures that the control flow analysis version of the signal input works with all TS versions currently supported. PR Close #57566
diff --git a/WORKSPACE b/WORKSPACE
@@ -181,3 +181,15 @@ http_archive(
     strip_prefix = "sc-4.8.2-osx",
     url = "https://saucelabs.com/downloads/sc-4.8.2-osx.zip",
 )
+
+yarn_install(
+    name = "npm_ts_versions",
+    data = [
+        YARN_LABEL,
+        "//:.yarnrc",
+    ],
+    exports_directories_only = False,
+    package_json = "//packages/core/schematics/migrations/signal-migration/test/ts-versions:package.json",
+    yarn = YARN_LABEL,
+    yarn_lock = "//packages/core/schematics/migrations/signal-migration/test/ts-versions:yarn.lock",
+)
diff --git a/packages/core/schematics/migrations/signal-migration/test/BUILD.bazel b/packages/core/schematics/migrations/signal-migration/test/BUILD.bazel
@@ -1,4 +1,5 @@
 load("@npm//@angular/build-tooling/bazel/integration:index.bzl", "integration_test")
+load("//packages/core/schematics/migrations/signal-migration/test/ts-versions:index.bzl", "TS_VERSIONS")
 load("//tools:defaults.bzl", "nodejs_binary", "ts_library")
 
 ts_library(
@@ -49,6 +50,32 @@ integration_test(
     },
 )
 
+[
+    integration_test(
+        name = "test_ts_%s" % version,
+        srcs = [
+            "golden.txt",
+            "//packages/core/schematics/migrations/signal-migration/test/golden-test:test_files",
+            "//packages/core/schematics/migrations/signal-migration/test/ts-versions:hooks.mjs",
+            "//packages/core/schematics/migrations/signal-migration/test/ts-versions:loader.mjs",
+        ],
+        commands = [
+            "$(rootpath //packages/core/schematics/migrations/signal-migration/src:bin) --node_options=--import=./ts-versions/loader.js ./golden-test/tsconfig.json",
+            "$(rootpath :golden_test_runner) ./golden-test ./golden.txt",
+        ],
+        data = [
+            ":golden_test_runner",
+            "//packages/core/schematics/migrations/signal-migration/src:bin",
+            "@npm_ts_versions//%s" % version,
+        ],
+        environment = {
+            "FORCE_COLOR": "3",
+            "TS_VERSION_PACKAGE": version,
+        },
+    )
+    for version in TS_VERSIONS
+]
+
 integration_test(
     name = "test_best_effort",
     srcs = [
diff --git a/packages/core/schematics/migrations/signal-migration/test/ts-versions/BUILD.bazel b/packages/core/schematics/migrations/signal-migration/test/ts-versions/BUILD.bazel
@@ -0,0 +1,6 @@
+exports_files([
+    "package.json",
+    "yarn.lock",
+    "loader.mjs",
+    "hooks.mjs",
+])
diff --git a/packages/core/schematics/migrations/signal-migration/test/ts-versions/hooks.mjs b/packages/core/schematics/migrations/signal-migration/test/ts-versions/hooks.mjs
@@ -0,0 +1,24 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+import {runfiles} from '@bazel/runfiles';
+
+const PACKAGE_PATH =
+    runfiles.resolve(`npm_ts_versions/node_modules/${process.env.TS_VERSION_PACKAGE}`);
+
+/**
+ * NodeJS hook that ensures TypeScript is imported from the configured
+ * TS version package. This allows us to conveniently test against multiple
+ * TS versions.
+ */
+export async function resolve(specifier, context, nextResolve) {
+  if (specifier === 'typescript') {
+    return nextResolve(`${PACKAGE_PATH}/lib/typescript.js`, context);
+  }
+  return nextResolve(specifier, context);
+}
diff --git a/packages/core/schematics/migrations/signal-migration/test/ts-versions/index.bzl b/packages/core/schematics/migrations/signal-migration/test/ts-versions/index.bzl
@@ -0,0 +1,7 @@
+"""Exposes information about the tested TS versions."""
+
+TS_VERSIONS = [
+    "typescript-5.5.4",
+    "typescript-5.5.3",
+    "typescript-5.5.2",
+]
diff --git a/packages/core/schematics/migrations/signal-migration/test/ts-versions/loader.mjs b/packages/core/schematics/migrations/signal-migration/test/ts-versions/loader.mjs
@@ -0,0 +1,12 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+import {register} from 'node:module';
+
+// Registers the TypeScript version loader.
+register('./hooks.mjs', import.meta.url);
diff --git a/packages/core/schematics/migrations/signal-migration/test/ts-versions/package.json b/packages/core/schematics/migrations/signal-migration/test/ts-versions/package.json
@@ -0,0 +1,9 @@
+{
+  "name": "ts-versions",
+  "license": "MIT",
+  "dependencies": {
+    "typescript-5.5.4": "npm:typescript@5.5.4",
+    "typescript-5.5.3": "npm:typescript@5.5.3",
+    "typescript-5.5.2": "npm:typescript@5.5.2"
+  }
+}
diff --git a/packages/core/schematics/migrations/signal-migration/test/ts-versions/yarn.lock b/packages/core/schematics/migrations/signal-migration/test/ts-versions/yarn.lock
@@ -0,0 +1,18 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+"typescript-5.5.2@npm:typescript@5.5.2":
+  version "5.5.2"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.2.tgz#c26f023cb0054e657ce04f72583ea2d85f8d0507"
+  integrity sha512-NcRtPEOsPFFWjobJEtfihkLCZCXZt/os3zf8nTxjVH3RvTSxjrCamJpbExGvYOF+tFHc3pA65qpdwPbzjohhew==
+
+"typescript-5.5.3@npm:typescript@5.5.3":
+  version "5.5.3"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.3.tgz#e1b0a3c394190838a0b168e771b0ad56a0af0faa"
+  integrity sha512-/hreyEujaB0w76zKo6717l3L0o/qEUtRgdvUBvlkhoWeOVMjMuHNHk0BRBzikzuGDqNmPQbg5ifMEqsHLiIUcQ==
+
+"typescript-5.5.4@npm:typescript@5.5.4":
+  version "5.5.4"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.4.tgz#d9852d6c82bad2d2eda4fd74a5762a8f5909e9ba"
+  integrity sha512-Mtq29sKDAEYP7aljRgtPOpTvOfbwRWlS6dPRzwjdE+C0R4brX/GUyhHSecbHMFLNBLcJIPt9nl9yG5TZ1weH+Q==
