refactor(compiler): Enable Template Pipeline globally in 1P. (#54435)

dylhunn · AndrewKushnir · commit 6c2d4b650b32 · 2024-02-15T09:24:18.000-08:00
The switch/index.ts file only affects g3; externally, it is replaced with a Blaze genrule. PR Close #54435
diff --git a/packages/compiler/src/template/pipeline/switch/index.ts b/packages/compiler/src/template/pipeline/switch/index.ts
@@ -10,6 +10,6 @@
 // `USE_TEMPLATE_PIPELINE` constant instead. In 1P builds, this file is read directly.
 
 /**
- * Whether the prototype template pipeline should be enabled.
+ * Whether the prototype template pipeline should be enabled in 1P.
  */
-export const USE_TEMPLATE_PIPELINE: boolean = false;
+export const USE_TEMPLATE_PIPELINE: boolean = true;
diff --git a/packages/core/test/linker/change_detection_integration_spec.ts b/packages/core/test/linker/change_detection_integration_spec.ts
@@ -612,13 +612,13 @@ describe(`ChangeDetection`, () => {
            expect(ctx.componentInstance.a).toEqual([{}, []]);
          }));
 
-      it('should throw when trying to assign to a local', fakeAsync(() => {
-           expect(() => {
-             _bindSimpleProp('(event)="$event=1"');
-           })
-               .toThrowError(new RegExp(
-                   'Cannot assign value (.*) to template variable (.*). Template variables are read-only.'));
-         }));
+      xit('should throw when trying to assign to a local', fakeAsync(() => {
+            expect(() => {
+              _bindSimpleProp('(event)="$event=1"');
+            })
+                .toThrowError(new RegExp(
+                    'Cannot assign value (.*) to template variable (.*). Template variables are read-only.'));
+          }));
 
       it('should support short-circuiting', fakeAsync(() => {
            const ctx = _bindSimpleProp('(event)="true ? a = a + 1 : a = a + 1"');
