feat(core): flipping the default value for standalone to true (#58169)

JeanMeche · devversion · commit 6b8c494d05e5 · 2024-10-15T16:05:14.000Z
With this commit directives, components & pipes are standalone by default. To be declared in an `NgModule`, those require now `standalone: false`. PR Close #58169
diff --git a/packages/compiler-cli/src/ngtsc/annotations/common/src/standalone-default-value.ts b/packages/compiler-cli/src/ngtsc/annotations/common/src/standalone-default-value.ts
@@ -10,4 +10,4 @@
  * A constant defining the default value for the standalone attribute in Directive and Pipes decorators.
  * Extracted to a separate file to facilitate G3 patches.
  */
-export const NG_STANDALONE_DEFAULT_VALUE = false;
+export const NG_STANDALONE_DEFAULT_VALUE = true;
diff --git a/packages/compiler/src/render3/partial/directive.ts b/packages/compiler/src/render3/partial/directive.ts
@@ -54,6 +54,7 @@ export function createDirectiveDefinitionMap(
   // e.g. `type: MyDirective`
   definitionMap.set('type', meta.type.value);
 
+  // TODO: standalone as default value (invert the condition)
   if (meta.isStandalone) {
     definitionMap.set('isStandalone', o.literal(meta.isStandalone));
   }
diff --git a/packages/compiler/src/render3/r3_pipe_compiler.ts b/packages/compiler/src/render3/r3_pipe_compiler.ts
@@ -60,6 +60,7 @@ export function compilePipeFromMetadata(metadata: R3PipeMetadata): R3CompiledExp
   // e.g. `pure: true`
   definitionMapValues.push({key: 'pure', value: o.literal(metadata.pure), quoted: false});
 
+  // TODO: standalone as default value (invert the condition)
   if (metadata.isStandalone) {
     definitionMapValues.push({key: 'standalone', value: o.literal(true), quoted: false});
   }
diff --git a/packages/core/src/render3/definition.ts b/packages/core/src/render3/definition.ts
@@ -636,6 +636,7 @@ export function getPipeDef<T>(type: any): PipeDef<T> | null {
  */
 export function isStandalone(type: Type<unknown>): boolean {
   const def = getComponentDef(type) || getDirectiveDef(type) || getPipeDef(type);
+  // TODO: standalone as default value (invert the condition)
   return def !== null ? def.standalone : false;
 }
 
@@ -664,6 +665,7 @@ function getNgDirectiveDef<T>(directiveDefinition: DirectiveDefinition<T>): Dire
     inputTransforms: null,
     inputConfig: directiveDefinition.inputs || EMPTY_OBJ,
     exportAs: directiveDefinition.exportAs || null,
+    // TODO: standalone as default value (invert the condition)
     standalone: directiveDefinition.standalone === true,
     signals: directiveDefinition.signals === true,
     selectors: directiveDefinition.selectors || EMPTY_ARRAY,
diff --git a/packages/core/src/render3/standalone-default-value.ts b/packages/core/src/render3/standalone-default-value.ts
@@ -10,4 +10,4 @@
  * A constant defining the default value for the standalone attribute in Directive and Pipes decorators.
  * Extracted to a separate file to facilitate G3 patches.
  */
-export const NG_STANDALONE_DEFAULT_VALUE = false;
+export const NG_STANDALONE_DEFAULT_VALUE = true;

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ export function createDirectiveDefinitionMap(`
`54`	`54`	// e.g. `type: MyDirective`
`55`	`55`	`definitionMap.set('type', meta.type.value);`
`56`	`56`
	`57`	`+ // TODO: standalone as default value (invert the condition)`
`57`	`58`	`if (meta.isStandalone) {`
`58`	`59`	`definitionMap.set('isStandalone', o.literal(meta.isStandalone));`
`59`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ export function compilePipeFromMetadata(metadata: R3PipeMetadata): R3CompiledExp`
`60`	`60`	// e.g. `pure: true`
`61`	`61`	`definitionMapValues.push({key: 'pure', value: o.literal(metadata.pure), quoted: false});`
`62`	`62`
	`63`	`+ // TODO: standalone as default value (invert the condition)`
`63`	`64`	`if (metadata.isStandalone) {`
`64`	`65`	`definitionMapValues.push({key: 'standalone', value: o.literal(true), quoted: false});`
`65`	`66`	`}`