fix(language-service): avoid generating TS suggestion diagnostics for templates (#56241)

clydin · thePunderWoman · commit 6ac209c24f46 · 2024-08-02T15:51:35.000Z
Angular's template files are not valid TypeScript. Attempting to get suggestion diagnostics from the underlying TypeScript language service will result in a large amount of false positives. Only actual TypeScript files should be analyzed by the underlying TypeScript language service for suggestions. PR Close #56241
diff --git a/packages/language-service/src/ts_plugin.ts b/packages/language-service/src/ts_plugin.ts
@@ -38,6 +38,15 @@ export function create(info: ts.server.PluginCreateInfo): NgLanguageService {
     return [];
   }
 
+  function getSuggestionDiagnostics(fileName: string): ts.DiagnosticWithLocation[] {
+    if (!angularOnly && isTypeScriptFile(fileName)) {
+      return tsLS.getSuggestionDiagnostics(fileName);
+    }
+
+    // Template files do not currently produce separate suggestion diagnostics
+    return [];
+  }
+
   function getSemanticDiagnostics(fileName: string): ts.Diagnostic[] {
     const diagnostics: ts.Diagnostic[] = [];
     if (!angularOnly && isTypeScriptFile(fileName)) {
@@ -311,6 +320,7 @@ export function create(info: ts.server.PluginCreateInfo): NgLanguageService {
     ...tsLS,
     getSyntacticDiagnostics,
     getSemanticDiagnostics,
+    getSuggestionDiagnostics,
     getTypeDefinitionAtPosition,
     getQuickInfoAtPosition,
     getDefinitionAtPosition,
