fix(core): SignalNode reactive node incorrectly exposing unset field (#53571)

devversion · atscott · commit 69b384c0d16f · 2024-01-04T12:07:12.000-08:00
The `SignalNode` interface, describing the reactive node for a `Signal`, seemingly exposes the `SIGNAL` symbol as a class member. This is not true as the `SIGNAL` reactive node only exists on the getter function, as a way to retrieve the signal underlying reactive node. This commit fixes this, enabling improved type-safety later, in a follow-up commit where `SIGNAL_NODE` can now be typed to match the `SignalNode` interface (unlike now where it's typed as just `object`). PR Close #53571
diff --git a/goldens/public-api/core/primitives/signals/index.md b/goldens/public-api/core/primitives/signals/index.md
@@ -106,8 +106,6 @@ export function signalMutateFn<T>(node: SignalNode<T>, mutator: (value: T) => vo
 
 // @public (undocumented)
 export interface SignalNode<T> extends ReactiveNode {
-    // (undocumented)
-    readonly [SIGNAL]: SignalNode<T>;
     // (undocumented)
     equal: ValueEqualityFn<T>;
     // (undocumented)
diff --git a/packages/core/primitives/signals/src/signal.ts b/packages/core/primitives/signals/src/signal.ts
@@ -25,7 +25,6 @@ let postSignalSetFn: (() => void)|null = null;
 export interface SignalNode<T> extends ReactiveNode {
   value: T;
   equal: ValueEqualityFn<T>;
-  readonly[SIGNAL]: SignalNode<T>;
 }
 
 export type SignalBaseGetter<T> = (() => T)&{readonly[SIGNAL]: unknown};

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ let postSignalSetFn: (() => void)\|null = null;`
`25`	`25`	`export interface SignalNode<T> extends ReactiveNode {`
`26`	`26`	`value: T;`
`27`	`27`	`equal: ValueEqualityFn<T>;`
`28`		`- readonly[SIGNAL]: SignalNode<T>;`
`29`	`28`	`}`
`30`	`29`
`31`	`30`	`export type SignalBaseGetter<T> = (() => T)&{readonly[SIGNAL]: unknown};`