feat(core): remove TestBed.get (#60414)

crisbeto · pkozlowski-opensource · commit 5e209cb560fd · 2025-03-19T15:52:26.000+01:00
`TestBed.get` isn't type safe and has been deprecated for several years now. These changes remove it from the public API and a follow-up change will add an automated migration to `TestBed.inject`. BREAKING CHANGE: * `TestBed.get` has been removed. Use `TestBed.inject` instead. PR Close #60414
diff --git a/goldens/public-api/core/testing/index.api.md b/goldens/public-api/core/testing/index.api.md
@@ -124,8 +124,6 @@ export interface TestBed {
     // (undocumented)
     execute(tokens: any[], fn: Function, context?: any): any;
     flushEffects(): void;
-    // @deprecated (undocumented)
-    get(token: any, notFoundValue?: any): any;
     initTestEnvironment(ngModule: Type<any> | Type<any>[], platform: PlatformRef, options?: TestEnvironmentOptions): void;
     // (undocumented)
     inject<T>(token: ProviderToken<T>, notFoundValue: undefined, options: InjectOptions & {
diff --git a/packages/common/http/test/module_spec.ts b/packages/common/http/test/module_spec.ts
@@ -79,14 +79,15 @@ class ReentrantInterceptor implements HttpInterceptor {
 describe('HttpClientModule', () => {
   let injector: Injector;
   beforeEach(() => {
-    injector = TestBed.configureTestingModule({
+    TestBed.configureTestingModule({
       imports: [HttpClientTestingModule],
       providers: [
         {provide: HTTP_INTERCEPTORS, useClass: InterceptorA, multi: true},
         {provide: HTTP_INTERCEPTORS, useClass: InterceptorB, multi: true},
         {provide: HTTP_INTERCEPTORS, useClass: InterceptorC, multi: true},
       ],
     });
+    injector = TestBed.inject(Injector);
   });
   it('initializes HttpClient properly', (done) => {
     injector
@@ -132,10 +133,11 @@ describe('HttpClientModule', () => {
   });
   it('allows interceptors to inject HttpClient', (done) => {
     TestBed.resetTestingModule();
-    injector = TestBed.configureTestingModule({
+    TestBed.configureTestingModule({
       imports: [HttpClientTestingModule],
       providers: [{provide: HTTP_INTERCEPTORS, useClass: ReentrantInterceptor, multi: true}],
     });
+    injector = TestBed.inject(Injector);
     injector
       .get(HttpClient)
       .get('/test')
diff --git a/packages/core/test/acceptance/di_spec.ts b/packages/core/test/acceptance/di_spec.ts
@@ -2873,7 +2873,7 @@ describe('di', () => {
         constructor(public injector: Injector) {}
       }
 
-      const testBedInjector: Injector = TestBed.get(Injector);
+      const testBedInjector = TestBed.inject(Injector);
       const childInjector = Injector.create({providers: [], parent: testBedInjector});
 
       const anyService = childInjector.get(AnyService);
diff --git a/packages/core/test/application_ref_integration_spec.ts b/packages/core/test/application_ref_integration_spec.ts
@@ -69,7 +69,7 @@ describe('ApplicationRef bootstrap', () => {
       expect(helloWorldComponent.log).toEqual(['OnInit', 'DoCheck', 'DoCheck']);
 
       // Cleanup TestabilityRegistry
-      const registry: TestabilityRegistry = getTestBed().get(TestabilityRegistry);
+      const registry = getTestBed().inject(TestabilityRegistry);
       registry.unregisterAllApplications();
     }),
   );
diff --git a/packages/core/test/application_ref_spec.ts b/packages/core/test/application_ref_spec.ts
@@ -17,10 +17,12 @@ import {
   Component,
   EnvironmentInjector,
   InjectionToken,
+  Injector,
   LOCALE_ID,
   NgModule,
   NgZone,
   PlatformRef,
+  ProviderToken,
   provideZoneChangeDetection,
   RendererFactory2,
   TemplateRef,
@@ -134,7 +136,7 @@ describe('bootstrap', () => {
 
       createRootEl();
       const modFactory = compiler.compileModuleSync(SomeModule);
-      const module = modFactory.create(TestBed);
+      const module = modFactory.create(TestBed.inject(Injector));
       const cmpFactory = module.componentFactoryResolver.resolveComponentFactory(SomeComponent);
       const component = app.bootstrap(cmpFactory);
 
@@ -162,7 +164,7 @@ describe('bootstrap', () => {
 
       createRootEl('custom-selector');
       const modFactory = compiler.compileModuleSync(SomeModule);
-      const module = modFactory.create(TestBed);
+      const module = modFactory.create(TestBed.inject(Injector));
       const cmpFactory = module.componentFactoryResolver.resolveComponentFactory(SomeComponent);
       const component = app.bootstrap(cmpFactory, 'custom-selector');
 
diff --git a/packages/core/test/linker/integration_spec.ts b/packages/core/test/linker/integration_spec.ts
@@ -1578,7 +1578,7 @@ describe('integration tests', function () {
     });
     const template = '<div><div *someImpvp="ctxBoolProp">hello</div></div>';
     TestBed.overrideComponent(MyComp, {set: {template}});
-    const anchorElement = getTestBed().get(ANCHOR_ELEMENT);
+    const anchorElement = getTestBed().inject(ANCHOR_ELEMENT);
     const fixture = TestBed.createComponent(MyComp);
 
     fixture.detectChanges();
diff --git a/packages/core/test/linker/security_integration_spec.ts b/packages/core/test/linker/security_integration_spec.ts
@@ -96,7 +96,7 @@ describe('security integration tests', function () {
       const template = `<a [href]="ctxProp">Link Title</a>`;
       TestBed.overrideComponent(SecuredComponent, {set: {template}});
       const fixture = TestBed.createComponent(SecuredComponent);
-      const sanitizer: DomSanitizer = getTestBed().get(DomSanitizer);
+      const sanitizer = getTestBed().inject(DomSanitizer);
 
       const e = fixture.debugElement.children[0].nativeElement;
       const ci = fixture.componentInstance;
@@ -110,7 +110,7 @@ describe('security integration tests', function () {
       const template = `<a [href]="ctxProp">Link Title</a>`;
       TestBed.overrideComponent(SecuredComponent, {set: {template}});
       const fixture = TestBed.createComponent(SecuredComponent);
-      const sanitizer: DomSanitizer = getTestBed().get(DomSanitizer);
+      const sanitizer = getTestBed().inject(DomSanitizer);
 
       const trusted = sanitizer.bypassSecurityTrustScript('javascript:alert(1)');
       const ci = fixture.componentInstance;
@@ -122,7 +122,7 @@ describe('security integration tests', function () {
       const template = `<a href="/foo/{{ctxProp}}">Link Title</a>`;
       TestBed.overrideComponent(SecuredComponent, {set: {template}});
       const fixture = TestBed.createComponent(SecuredComponent);
-      const sanitizer: DomSanitizer = getTestBed().get(DomSanitizer);
+      const sanitizer: DomSanitizer = getTestBed().inject(DomSanitizer);
 
       const e = fixture.debugElement.children[0].nativeElement;
       const trusted = sanitizer.bypassSecurityTrustUrl('bar/baz');
diff --git a/packages/core/test/render3/providers_spec.ts b/packages/core/test/render3/providers_spec.ts
@@ -1095,7 +1095,7 @@ describe('providers', () => {
 
       const environmentInjector = createEnvironmentInjector(
         [{provide: String, useValue: 'From module injector'}],
-        TestBed.get(EnvironmentInjector),
+        TestBed.inject(EnvironmentInjector),
       );
 
       hostComponent!.vcref.createComponent(EmbeddedComponent, {
diff --git a/packages/core/testing/src/test_bed.ts b/packages/core/testing/src/test_bed.ts
@@ -115,9 +115,6 @@ export interface TestBed {
   ): T | null;
   inject<T>(token: ProviderToken<T>, notFoundValue?: T, options?: InjectOptions): T;
 
-  /** @deprecated from v9.0.0 use TestBed.inject */
-  get(token: any, notFoundValue?: any): any;
-
   /**
    * Runs the given function in the `EnvironmentInjector` context of `TestBed`.
    *
@@ -364,17 +361,6 @@ export class TestBedImpl implements TestBed {
     return TestBedImpl.INSTANCE.inject(token, notFoundValue, options);
   }
 
-  /** @deprecated from v9.0.0 use TestBed.inject */
-  static get(token: any, notFoundValue?: any): any;
-  /** @deprecated from v9.0.0 use TestBed.inject */
-  static get(
-    token: any,
-    notFoundValue: any = Injector.THROW_IF_NOT_FOUND,
-    options?: InjectOptions,
-  ): any {
-    return TestBedImpl.INSTANCE.inject(token, notFoundValue, options);
-  }
-
   /**
    * Runs the given function in the `EnvironmentInjector` context of `TestBed`.
    *
@@ -575,13 +561,6 @@ export class TestBedImpl implements TestBed {
       : result;
   }
 
-  /** @deprecated from v9.0.0 use TestBed.inject */
-  get(token: any, notFoundValue?: any): any;
-  /** @deprecated from v9.0.0 use TestBed.inject */
-  get(token: any, notFoundValue: any = Injector.THROW_IF_NOT_FOUND, options?: InjectOptions): any {
-    return this.inject(token, notFoundValue, options);
-  }
-
   runInInjectionContext<T>(fn: () => T): T {
     return runInInjectionContext(this.inject(EnvironmentInjector), fn);
   }
diff --git a/packages/misc/angular-in-memory-web-api/test/http-client-backend-service_spec.ts b/packages/misc/angular-in-memory-web-api/test/http-client-backend-service_spec.ts
@@ -49,7 +49,7 @@ describe('HttpClient Backend Service', () => {
         ],
       });
 
-      http = TestBed.get(HttpClient);
+      http = TestBed.inject(HttpClient);
     });
 
     it('can get heroes', waitForAsync(() => {
@@ -62,7 +62,7 @@ describe('HttpClient Backend Service', () => {
     }));
 
     it('GET should be a "cold" observable', waitForAsync(() => {
-      const httpBackend = TestBed.get(HttpBackend);
+      const httpBackend = TestBed.inject<any>(HttpBackend);
       const spy = spyOn(httpBackend, 'collectionHandler').and.callThrough();
       const get$ = http.get<Hero[]>('api/heroes');
 
@@ -88,7 +88,7 @@ describe('HttpClient Backend Service', () => {
     }));
 
     it('Should only initialize the db once', waitForAsync(() => {
-      const httpBackend = TestBed.get(HttpBackend);
+      const httpBackend = TestBed.inject<any>(HttpBackend);
       const spy = spyOn(httpBackend, 'resetDb').and.callThrough();
 
       // Simultaneous backend.handler calls
@@ -252,7 +252,7 @@ describe('HttpClient Backend Service', () => {
         ],
       });
 
-      http = TestBed.get(HttpClient);
+      http = TestBed.inject(HttpClient);
     });
 
     it('can get heroes', waitForAsync(() => {
@@ -377,7 +377,7 @@ describe('HttpClient Backend Service', () => {
       let heroService: HeroService;
 
       beforeEach(() => {
-        heroService = TestBed.get(HeroService);
+        heroService = TestBed.inject(HeroService);
       });
 
       it('can get heroes', waitForAsync(() => {
@@ -499,9 +499,9 @@ describe('HttpClient Backend Service', () => {
         ],
       });
 
-      http = TestBed.get(HttpClient);
-      httpBackend = TestBed.get(HttpBackend);
-      interceptors = TestBed.get(HTTP_INTERCEPTORS);
+      http = TestBed.inject(HttpClient);
+      httpBackend = TestBed.inject<any>(HttpBackend);
+      interceptors = TestBed.inject<any>(HTTP_INTERCEPTORS);
     });
 
     // sanity test
@@ -560,8 +560,8 @@ describe('HttpClient Backend Service', () => {
         ],
       });
 
-      http = TestBed.get(HttpClient);
-      httpBackend = TestBed.get(HttpBackend);
+      http = TestBed.inject(HttpClient);
+      httpBackend = TestBed.inject<any>(HttpBackend);
       createPassThruBackend = spyOn(<any>httpBackend, 'createPassThruBackend').and.callThrough();
     });
 
@@ -623,7 +623,7 @@ describe('HttpClient Backend Service', () => {
         ],
       });
 
-      http = TestBed.get(HttpClient);
+      http = TestBed.inject(HttpClient);
     });
 
     it('can get heroes (encapsulated)', waitForAsync(() => {
diff --git a/packages/platform-browser/test/dom/events/hammer_gestures_spec.ts b/packages/platform-browser/test/dom/events/hammer_gestures_spec.ts
@@ -5,7 +5,7 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.dev/license
  */
-import {ApplicationRef, NgZone} from '@angular/core';
+import {ApplicationRef, Injector, NgZone} from '@angular/core';
 import {fakeAsync, inject, TestBed, tick} from '@angular/core/testing';
 import {EventManager} from '@angular/platform-browser';
 import {
@@ -24,7 +24,11 @@ describe('HammerGesturesPlugin', () => {
 
   describe('with no custom loader', () => {
     beforeEach(() => {
-      plugin = new HammerGesturesPlugin(document, new HammerGestureConfig(), TestBed);
+      plugin = new HammerGesturesPlugin(
+        document,
+        new HammerGestureConfig(),
+        TestBed.inject(Injector),
+      );
     });
 
     it('should warn user and do nothing when Hammer.js not loaded', () => {
@@ -86,7 +90,7 @@ describe('HammerGesturesPlugin', () => {
       const hammerConfig = new HammerGestureConfig();
       spyOn(hammerConfig, 'buildHammer').and.returnValue(fakeHammerInstance);
 
-      plugin = new HammerGesturesPlugin(document, hammerConfig, TestBed, loader);
+      plugin = new HammerGesturesPlugin(document, hammerConfig, TestBed.inject(Injector), loader);
 
       // Use a fake EventManager that has access to the NgZone.
       plugin.manager = {getZone: () => ngZone} as EventManager;
diff --git a/packages/platform-browser/test/testing_public_spec.ts b/packages/platform-browser/test/testing_public_spec.ts
@@ -527,7 +527,7 @@ describe('public testing API', () => {
             'resolveComponentFactory',
           ]);
           TestBed.overrideProvider(ComponentFactoryResolver, {useValue: componentFactoryMock});
-          expect(TestBed.get(ComponentFactoryResolver)).toEqual(componentFactoryMock);
+          expect(TestBed.inject(ComponentFactoryResolver)).toEqual(componentFactoryMock);
         });
       });
 
@@ -598,7 +598,9 @@ describe('public testing API', () => {
 
           const compiler = TestBed.inject(Compiler);
           const modFactory = compiler.compileModuleSync(MyModule);
-          expect(modFactory.create(getTestBed()).injector.get(aTok)).toBe('mockA: parentDepValue');
+          expect(modFactory.create(TestBed.inject(Injector)).injector.get(aTok)).toBe(
+            'mockA: parentDepValue',
+          );
         });
 
         it('should keep imported NgModules eager', () => {
diff --git a/packages/router/test/regression_integration.spec.ts b/packages/router/test/regression_integration.spec.ts
@@ -218,7 +218,7 @@ describe('Integration', () => {
         declarations: [OnPushComponent, SimpleCmp],
       });
 
-      const router: Router = TestBed.get(Router);
+      const router = TestBed.inject(Router);
       const fixture = createRoot(router, OnPushComponent);
       router.navigateByUrl('/simple');
       advance(fixture);
diff --git a/packages/router/test/router_preloader.spec.ts b/packages/router/test/router_preloader.spec.ts
@@ -60,7 +60,7 @@ describe('RouterPreloader', () => {
     });
 
     it('being destroyed before expected', () => {
-      const preloader: RouterPreloader = TestBed.get(RouterPreloader);
+      const preloader = TestBed.inject(RouterPreloader);
       // Calling the RouterPreloader's ngOnDestroy method is done to simulate what would happen if
       // the containing NgModule is destroyed.
       expect(() => preloader.ngOnDestroy()).not.toThrow();
diff --git a/packages/upgrade/src/common/test/downgrade_component_adapter_spec.ts b/packages/upgrade/src/common/test/downgrade_component_adapter_spec.ts
@@ -168,9 +168,10 @@ withEachNg1Version(() => {
         class NewModule {}
 
         const modFactory = compiler.compileModuleSync(NewModule);
-        const module = modFactory.create(TestBed);
+        const testBedInjector = TestBed.inject(Injector);
+        const module = modFactory.create(testBedInjector);
         componentFactory = module.componentFactoryResolver.resolveComponentFactory(NewComponent)!;
-        parentInjector = TestBed;
+        parentInjector = testBedInjector;
 
         return new DowngradeComponentAdapter(
           element,

Original file line number	Diff line number	Diff line change
`@@ -2873,7 +2873,7 @@ describe('di', () => {`
`2873`	`2873`	`constructor(public injector: Injector) {}`
`2874`	`2874`	`}`
`2875`	`2875`
`2876`		`- const testBedInjector: Injector = TestBed.get(Injector);`
	`2876`	`+ const testBedInjector = TestBed.inject(Injector);`
`2877`	`2877`	`const childInjector = Injector.create({providers: [], parent: testBedInjector});`
`2878`	`2878`
`2879`	`2879`	`const anyService = childInjector.get(AnyService);`