refactor(core): Update Transition finished promise to not throw unhandled rejection (#60816)

atscott · kirjs · commit 5cd80525e7e9 · 2025-04-15T18:40:43.000-04:00
As with `InternalNavigationResult`, this commit adds the `catch` to the `finished` promise on `InternalNavigationTransition` to avoid unhandled promise rejections. PR Close #60816
diff --git a/packages/core/primitives/dom-navigation/testing/fake_navigation.ts b/packages/core/primitives/dom-navigation/testing/fake_navigation.ts
@@ -1145,6 +1145,8 @@ class InternalNavigationTransition implements NavigationTransition {
       this.finishedReject = reject;
       this.finishedResolve = resolve;
     });
+    // All rejections are handled.
+    this.finished.catch(() => {});
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1145,6 +1145,8 @@ class InternalNavigationTransition implements NavigationTransition {`
`1145`	`1145`	`this.finishedReject = reject;`
`1146`	`1146`	`this.finishedResolve = resolve;`
`1147`	`1147`	`});`
	`1148`	`+ // All rejections are handled.`
	`1149`	`+ this.finished.catch(() => {});`
`1148`	`1150`	`}`
`1149`	`1151`	`}`
`1150`	`1152`