fix(compiler-cli): remove unnecessary escaping in regex expressions (#51554)

josephperrott · thePunderWoman · commit 5c36fc784f29 · 2023-08-29T21:52:34.000Z
Correct various Useless regular-expression character escape issues. PR Close #51554
diff --git a/packages/compiler-cli/test/compliance/test_helpers/di_checks.ts b/packages/compiler-cli/test/compliance/test_helpers/di_checks.ts
@@ -10,7 +10,7 @@
  * Verifies that there is exactly one factory definition for the provided type.
  */
 export function verifyUniqueFactory(output: string, type: string): boolean {
-  const matches = output.match(new RegExp(type + '\.ɵfac =', 'g'));
+  const matches = output.match(new RegExp(type + '.ɵfac =', 'g'));
   if (matches === null) {
     return false;
   }
diff --git a/packages/compiler-cli/test/compliance/test_helpers/expected_file_macros.ts b/packages/compiler-cli/test/compliance/test_helpers/expected_file_macros.ts
@@ -203,7 +203,7 @@ function flagUnion(pattern: RegExp, getFlagValue: (...match: string[]) => number
   return [
     // Match at least one occurrence of the pattern, optionally followed by more occurrences
     // separated by a pipe.
-    new RegExp(pattern.source + '(?:\s*\\\|\s*' + pattern.source + ')*', 'g'),
+    new RegExp(pattern.source + '(?:s*\\\|s*' + pattern.source + ')*', 'g'),
     (match: string) => {
       // Replace all matches with the union of the individually matched flags.
       return String(match.split('|')

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Verifies that there is exactly one factory definition for the provided type.`
`11`	`11`	`*/`
`12`	`12`	`export function verifyUniqueFactory(output: string, type: string): boolean {`
`13`		`- const matches = output.match(new RegExp(type + '\.ɵfac =', 'g'));`
	`13`	`+ const matches = output.match(new RegExp(type + '.ɵfac =', 'g'));`
`14`	`14`	`if (matches === null) {`
`15`	`15`	`return false;`
`16`	`16`	`}`