fix(compiler-cli): handle new expressions when extracting dependencies (#59637)

clydin · AndrewKushnir · commit 5a13dff22c22 · 2025-01-21T10:47:43.000-08:00
Updates the HMR dependencies extraction logic to handle new expressions. For example, `deps: [[new Optional(), dep]]`. PR Close #59637
diff --git a/packages/compiler-cli/src/ngtsc/hmr/src/extract_dependencies.ts b/packages/compiler-cli/src/ngtsc/hmr/src/extract_dependencies.ts
@@ -245,7 +245,8 @@ class PotentialTopLevelReadsVisitor extends o.RecursiveAstVisitor {
       ts.isWhileStatement(parent) ||
       ts.isSwitchStatement(parent) ||
       ts.isCaseClause(parent) ||
-      ts.isThrowStatement(parent)
+      ts.isThrowStatement(parent) ||
+      ts.isNewExpression(parent)
     ) {
       return parent.expression === node;
     }
diff --git a/packages/compiler-cli/test/ngtsc/hmr_spec.ts b/packages/compiler-cli/test/ngtsc/hmr_spec.ts
@@ -616,6 +616,43 @@ runInEachFileSystem(() => {
       );
     });
 
+    it('should capture new expression dependencies', () => {
+      enableHmr();
+      env.write(
+        'test.ts',
+        `
+          import {Component, InjectionToken, Optional} from '@angular/core';
+          const token = new InjectionToken<number>('TEST');
+          const dep = new InjectionToken<number>('TEST-DEP');
+          const value = 5;
+          @Component({
+            template: '',
+            providers: [{
+              provide: token,
+              useFactory: () => {
+                const v = value;
+                return v;
+              },
+              deps: [[new Optional(), dep]]
+            }]
+          })
+          export class Cmp {}
+        `,
+      );
+
+      env.driveMain();
+
+      const jsContents = env.getContents('test.js');
+      const hmrContents = env.driveHmr('test.ts', 'Cmp');
+
+      expect(jsContents).toContain(
+        'ɵɵreplaceMetadata(Cmp, m.default, [i0], [token, value, Optional, dep, Component]));',
+      );
+      expect(hmrContents).toContain(
+        'export default function Cmp_UpdateMetadata(Cmp, ɵɵnamespaces, token, value, Optional, dep, Component) {',
+      );
+    });
+
     it('should preserve eager standalone imports in HMR even if they are not used in the template', () => {
       enableHmr({
         // Disable class metadata since it can add noise to the test.
