fix(core): avoid injecting internal error handler from a destroyed injector (#62275)

arturovt · AndrewKushnir · commit 538de86a7256 · 2025-08-27T11:35:54.000-07:00
This commit prevents lazy injection of the internal `ErrorHandler` from a destroyed injector, which would otherwise result in a secondary "destroyed injector" error. The `handleUncaughtError` function is used in a wrapped event listener that invokes the `ErrorHandler` if the listener throws. A simple case in a micro-frontend application: ```ts onNavigationToAnotherApp() { this.appRef.destroy(); do_some_stuff_ie_loggin_that_may_throw(); } ``` If the function throws an error, Angular attempts to inject the `ErrorHandler` from a destroyed injector. PR Close #62275
diff --git a/packages/core/src/render3/instructions/shared.ts b/packages/core/src/render3/instructions/shared.ts
@@ -705,7 +705,12 @@ export function handleUncaughtError(lView: LView, error: any): void {
   if (!injector) {
     return;
   }
-  const errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null);
+  let errorHandler: ((e: any) => void) | null;
+  try {
+    errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null);
+  } catch {
+    errorHandler = null;
+  }
   errorHandler?.(error);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -705,7 +705,12 @@ export function handleUncaughtError(lView: LView, error: any): void {`
`705`	`705`	`if (!injector) {`
`706`	`706`	`return;`
`707`	`707`	`}`
`708`		`- const errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null);`
	`708`	`+ let errorHandler: ((e: any) => void) \| null;`
	`709`	`+ try {`
	`710`	`+ errorHandler = injector.get(INTERNAL_APPLICATION_ERROR_HANDLER, null);`
	`711`	`+ } catch {`
	`712`	`+ errorHandler = null;`
	`713`	`+ }`
`709`	`714`	`errorHandler?.(error);`
`710`	`715`	`}`
`711`	`716`