Revert "refactor(http): Improves base64 encoding/decoding with feature detection (#67002)"

thePunderWoman · thePunderWoman · commit 5338b5912c7d · 2026-03-04T09:19:10.000-08:00
This reverts commit aafeb1d.
diff --git a/packages/common/http/src/transfer_cache.ts b/packages/common/http/src/transfer_cache.ts
@@ -29,7 +29,6 @@ import {HTTP_ROOT_INTERCEPTOR_FNS, HttpHandlerFn} from './interceptor';
 import {HttpRequest} from './request';
 import {HttpEvent, HttpResponse} from './response';
 import {HttpParams} from './params';
-import {fromBase64, toBase64} from './util';
 
 /**
  * Options to configure how TransferCache should be used to cache requests made via HttpClient.
@@ -273,7 +272,7 @@ export function transferCacheInterceptorFn(
           transferState.set<TransferHttpResponse>(storeKey, {
             [BODY]:
               req.responseType === 'arraybuffer' || req.responseType === 'blob'
-                ? toBase64(event.body as ArrayBufferLike)
+                ? toBase64(event.body)
                 : event.body,
             [HEADERS]: getFilteredHeaders(event.headers, headersToInclude),
             [STATUS]: event.status,
@@ -361,6 +360,28 @@ function generateHash(value: string): string {
   return hash.toString();
 }
 
+function toBase64(buffer: unknown): string {
+  //TODO: replace with when is Baseline widely available
+  // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array/toBase64
+  const bytes = new Uint8Array(buffer as ArrayBufferLike);
+
+  const CHUNK_SIZE = 0x8000; // 32,768 bytes (~32 KB) per chunk, to avoid stack overflow
+
+  let binaryString = '';
+
+  for (let i = 0; i < bytes.length; i += CHUNK_SIZE) {
+    const chunk = bytes.subarray(i, i + CHUNK_SIZE);
+    binaryString += String.fromCharCode.apply(null, chunk as unknown as number[]);
+  }
+  return btoa(binaryString);
+}
+
+function fromBase64(base64: string): ArrayBuffer {
+  const binary = atob(base64);
+  const bytes = Uint8Array.from(binary, (c) => c.charCodeAt(0));
+  return bytes.buffer;
+}
+
 /**
  * Returns the DI providers needed to enable HTTP transfer cache.
  *
diff --git a/packages/common/http/src/util.ts b/packages/common/http/src/util.ts
diff --git a/packages/core/test/bundling/hydration/bundle.golden_symbols.json b/packages/core/test/bundling/hydration/bundle.golden_symbols.json
@@ -531,7 +531,6 @@
       "hasApplyArgsData",
       "hasAuthHeaders",
       "hasDeps",
-      "hasFromBase64",
       "hasInSkipHydrationBlockFlag",
       "hasLift",
       "hasMatchingDehydratedView",
