fix(core): tree shake version class (#53598)

crisbeto · thePunderWoman · commit 513fee871eb5 · 2023-12-18T16:26:36.000Z
Core bundles were retaining the `Version` class and `VERSION` constant, because we stamp out the current version in the DOM. This shouldn't be necessary, because any usage of `0.0.0-PLACEHOLDER` will be replaced with the current version at build time. These changes remove the reference so it can be tree shaken away. PR Close #53598
diff --git a/packages/core/src/render3/component_ref.ts b/packages/core/src/render3/component_ref.ts
@@ -23,7 +23,6 @@ import {NgModuleRef} from '../linker/ng_module_factory';
 import {Renderer2, RendererFactory2} from '../render/api';
 import {Sanitizer} from '../sanitization/sanitizer';
 import {assertDefined, assertGreaterThan, assertIndexInRange} from '../util/assert';
-import {VERSION} from '../version';
 import {NOT_FOUND_CHECK_ONLY_ELEMENT_INJECTOR} from '../view/provider_flags';
 
 import {AfterRenderEventManager} from './after_render_hooks';
@@ -501,7 +500,8 @@ function setRootNodeAttributes(
     hostRenderer: Renderer2, componentDef: ComponentDef<unknown>, hostRNode: RElement,
     rootSelectorOrNode: any) {
   if (rootSelectorOrNode) {
-    setUpAttributes(hostRenderer, hostRNode, ['ng-version', VERSION.full]);
+    // The placeholder will be replaced with the actual version at build time.
+    setUpAttributes(hostRenderer, hostRNode, ['ng-version', '0.0.0-PLACEHOLDER']);
   } else {
     // If host element is created as a part of this function call (i.e. `rootSelectorOrNode`
     // is not defined), also apply attributes and classes extracted from component selector.
diff --git a/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
@@ -530,9 +530,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/animations/bundle.golden_symbols.json b/packages/core/test/bundling/animations/bundle.golden_symbols.json
@@ -587,9 +587,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
@@ -446,9 +446,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/defer/bundle.golden_symbols.json b/packages/core/test/bundling/defer/bundle.golden_symbols.json
@@ -491,9 +491,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VIEW_REFS"
   },
diff --git a/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json b/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
@@ -590,9 +590,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VE_ViewContainerRef"
   },
diff --git a/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json b/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
@@ -584,9 +584,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VE_ViewContainerRef"
   },
diff --git a/packages/core/test/bundling/hello_world/bundle.golden_symbols.json b/packages/core/test/bundling/hello_world/bundle.golden_symbols.json
@@ -338,9 +338,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/hydration/bundle.golden_symbols.json b/packages/core/test/bundling/hydration/bundle.golden_symbols.json
@@ -518,9 +518,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -812,9 +812,6 @@
   {
     "name": "UrlTree"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VE_ViewContainerRef"
   },
diff --git a/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json b/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json
@@ -395,9 +395,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/todo/bundle.golden_symbols.json b/packages/core/test/bundling/todo/bundle.golden_symbols.json
@@ -509,9 +509,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VE_ViewContainerRef"
   },

Original file line number	Diff line number	Diff line change
`@@ -530,9 +530,6 @@`
`530`	`530`	`{`
`531`	`531`	`"name": "UnsubscriptionError"`
`532`	`532`	`},`
`533`		`- {`
`534`		`- "name": "VERSION"`
`535`		`- },`
`536`	`533`	`{`
`537`	`534`	`"name": "ViewEncapsulation"`
`538`	`535`	`},`
Original file line number	Diff line number	Diff line change
`@@ -587,9 +587,6 @@`
`587`	`587`	`{`
`588`	`588`	`"name": "UnsubscriptionError"`
`589`	`589`	`},`
`590`		`- {`
`591`		`- "name": "VERSION"`
`592`		`- },`
`593`	`590`	`{`
`594`	`591`	`"name": "ViewEncapsulation"`
`595`	`592`	`},`
Original file line number	Diff line number	Diff line change
`@@ -446,9 +446,6 @@`
`446`	`446`	`{`
`447`	`447`	`"name": "UnsubscriptionError"`
`448`	`448`	`},`
`449`		`- {`
`450`		`- "name": "VERSION"`
`451`		`- },`
`452`	`449`	`{`
`453`	`450`	`"name": "ViewEncapsulation"`
`454`	`451`	`},`
Original file line number	Diff line number	Diff line change
`@@ -491,9 +491,6 @@`
`491`	`491`	`{`
`492`	`492`	`"name": "UnsubscriptionError"`
`493`	`493`	`},`
`494`		`- {`
`495`		`- "name": "VERSION"`
`496`		`- },`
`497`	`494`	`{`
`498`	`495`	`"name": "VIEW_REFS"`
`499`	`496`	`},`
Original file line number	Diff line number	Diff line change
`@@ -590,9 +590,6 @@`
`590`	`590`	`{`
`591`	`591`	`"name": "UnsubscriptionError"`
`592`	`592`	`},`
`593`		`- {`
`594`		`- "name": "VERSION"`
`595`		`- },`
`596`	`593`	`{`
`597`	`594`	`"name": "VE_ViewContainerRef"`
`598`	`595`	`},`
Original file line number	Diff line number	Diff line change
`@@ -584,9 +584,6 @@`
`584`	`584`	`{`
`585`	`585`	`"name": "UnsubscriptionError"`
`586`	`586`	`},`
`587`		`- {`
`588`		`- "name": "VERSION"`
`589`		`- },`
`590`	`587`	`{`
`591`	`588`	`"name": "VE_ViewContainerRef"`
`592`	`589`	`},`
Original file line number	Diff line number	Diff line change
`@@ -338,9 +338,6 @@`
`338`	`338`	`{`
`339`	`339`	`"name": "UnsubscriptionError"`
`340`	`340`	`},`
`341`		`- {`
`342`		`- "name": "VERSION"`
`343`		`- },`
`344`	`341`	`{`
`345`	`342`	`"name": "ViewEncapsulation"`
`346`	`343`	`},`
Original file line number	Diff line number	Diff line change
`@@ -518,9 +518,6 @@`
`518`	`518`	`{`
`519`	`519`	`"name": "UnsubscriptionError"`
`520`	`520`	`},`
`521`		`- {`
`522`		`- "name": "VERSION"`
`523`		`- },`
`524`	`521`	`{`
`525`	`522`	`"name": "ViewEncapsulation"`
`526`	`523`	`},`
Original file line number	Diff line number	Diff line change
`@@ -812,9 +812,6 @@`
`812`	`812`	`{`
`813`	`813`	`"name": "UrlTree"`
`814`	`814`	`},`
`815`		`- {`
`816`		`- "name": "VERSION"`
`817`		`- },`
`818`	`815`	`{`
`819`	`816`	`"name": "VE_ViewContainerRef"`
`820`	`817`	`},`