fix(core): correctly clear template HMR internal renderer cache (#58724)

clydin · AndrewKushnir · commit 502ee0e7221a · 2024-11-19T12:18:40.000-08:00
The internal renderer cache within the renderer factory was not being correctly cleared due to a type-casting error. This prevented template HMR from correctly updating the component. A more explicity cast has now been used to mitigate this problem. Component template HMR is currently considered experimental. PR Close #58724
diff --git a/packages/core/src/render3/hmr.ts b/packages/core/src/render3/hmr.ts
@@ -123,9 +123,9 @@ function recreateMatchingLViews(def: ComponentDef<unknown>, rootLView: LView): v
  * @param def A ComponentDef instance.
  */
 function clearRendererCache(factory: RendererFactory, def: ComponentDef<unknown>) {
-  // Cast to `any` to read a private field.
+  // Cast to read a private field.
   // NOTE: This must be kept synchronized with the renderer factory implementation in platform-browser.
-  (factory as any).rendererByCompId?.remove(def.id);
+  (factory as {rendererByCompId?: Map<string, unknown>}).rendererByCompId?.delete(def.id);
 }
 
 /**
