refactor(http): simplifies destruction tracking using destroyed property

SkyZeroZx · atscott · commit 44435ea97ba5 · 2025-11-05T17:05:24.000Z
Replaces the manual destroyed state with destroyed property
diff --git a/goldens/public-api/common/http/index.api.md b/goldens/public-api/common/http/index.api.md
@@ -19,7 +19,6 @@ import { WritableResource } from '@angular/core';
 
 // @public
 export class FetchBackend implements HttpBackend {
-    constructor();
     // (undocumented)
     handle(request: HttpRequest<any>): Observable<HttpEvent<any>>;
     // (undocumented)
diff --git a/packages/common/http/src/fetch.ts b/packages/common/http/src/fetch.ts
@@ -63,13 +63,6 @@ export class FetchBackend implements HttpBackend {
     inject(FetchFactory, {optional: true})?.fetch ?? ((...args) => globalThis.fetch(...args));
   private readonly ngZone = inject(NgZone);
   private readonly destroyRef = inject(DestroyRef);
-  private destroyed = false;
-
-  constructor() {
-    this.destroyRef.onDestroy(() => {
-      this.destroyed = true;
-    });
-  }
 
   handle(request: HttpRequest<any>): Observable<HttpEvent<any>> {
     return new Observable((observer) => {
@@ -174,7 +167,7 @@ export class FetchBackend implements HttpBackend {
           // unnecessary work or triggering side effects after teardown.
           // This may happen if the app was explicitly destroyed before
           // the response returned entirely.
-          if (this.destroyed) {
+          if (this.destroyRef.destroyed) {
             // Streams left in a pending state (due to `break` without cancel) may
             // continue consuming or holding onto data behind the scenes.
             // Calling `reader.cancel()` allows the browser or the underlying
