fix(core): skip component ID collision warning during SSR (#59625)

crisbeto · AndrewKushnir · commit 431166d93fd3 · 2025-01-21T09:56:52.000-08:00
The component ID collision check tries to account for components being replaced by checking for the `type`, however that might not work during SSR. These changes disable the warning since it's primarily useful on the browser anyways. PR Close #59625
diff --git a/packages/core/src/render3/definition.ts b/packages/core/src/render3/definition.ts
@@ -750,7 +750,13 @@ function getComponentId<T>(componentDef: ComponentDef<T>): string {
 
   const compId = 'c' + hash;
 
-  if (typeof ngDevMode === 'undefined' || ngDevMode) {
+  if (
+    (typeof ngDevMode === 'undefined' || ngDevMode) &&
+    // Skip the check on the server since we can't guarantee the same component instance between
+    // requests. Note that we can't use DI to check if we're on the server, because the component
+    // hasn't been instantiated yet.
+    (typeof ngServerMode === 'undefined' || !ngServerMode)
+  ) {
     if (GENERATED_COMP_IDS.has(compId)) {
       const previousCompDefType = GENERATED_COMP_IDS.get(compId)!;
       if (previousCompDefType !== componentDef.type) {
