fix(core): Fix a bug where snapshotted functions are being run twice if they return a nullish/falsey value. (#59073)

arielbackenroth · alxhub · commit 34ded10fa606 · 2024-12-05T16:16:49.000-08:00
Snapshots can return nullish values; don't run the snapshotted function if the snapshotted function returns a nullish/falsey value. PR Close #59073
diff --git a/packages/core/src/render3/after_render/manager.ts b/packages/core/src/render3/after_render/manager.ts
@@ -135,7 +135,7 @@ export class AfterRenderImpl {
 
   protected maybeTrace<T>(fn: () => T, snapshot: TracingSnapshot | null): T {
     // Only trace the execution if the snapshot is defined.
-    return snapshot?.run(TracingAction.AFTER_NEXT_RENDER, fn) ?? fn();
+    return snapshot ? snapshot.run(TracingAction.AFTER_NEXT_RENDER, fn) : fn();
   }
 
   /** @nocollapse */

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ export class AfterRenderImpl {`
`135`	`135`
`136`	`136`	`protected maybeTrace<T>(fn: () => T, snapshot: TracingSnapshot \| null): T {`
`137`	`137`	`// Only trace the execution if the snapshot is defined.`
`138`		`- return snapshot?.run(TracingAction.AFTER_NEXT_RENDER, fn) ?? fn();`
	`138`	`+ return snapshot ? snapshot.run(TracingAction.AFTER_NEXT_RENDER, fn) : fn();`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`/** @nocollapse */`