fix(core): handle local refs when getDeferBlocks is invoked in tests (#52973)

AndrewKushnir · AndrewKushnir · commit 31a1575334ef · 2023-11-16T12:20:55.000-08:00
This commit fixes an issue where having elements with local refs in some cases causes JS exception. PR Close #52973
diff --git a/packages/core/src/defer/utils.ts b/packages/core/src/defer/utils.ts
@@ -141,6 +141,6 @@ export function assertDeferredDependenciesLoaded(tDetails: TDeferBlockDetails) {
  * that a primary template exists. All the other template options are optional.
  */
 export function isTDeferBlockDetails(value: unknown): value is TDeferBlockDetails {
-  return (typeof value === 'object') &&
+  return value !== null && (typeof value === 'object') &&
       (typeof (value as TDeferBlockDetails).primaryTmplIndex === 'number');
 }
diff --git a/packages/core/test/defer_fixture_spec.ts b/packages/core/test/defer_fixture_spec.ts
@@ -190,6 +190,39 @@ describe('DeferFixture', () => {
     expect(el.querySelector('.more')).toBeDefined();
   });
 
+  it('should work with templates that have local refs', async () => {
+    @Component({
+      selector: 'defer-comp',
+      standalone: true,
+      imports: [SecondDeferredComp],
+      template: `
+        <ng-template #template>Hello</ng-template>
+        <div>
+          @defer (on immediate) {
+            <second-deferred-comp />
+          }
+        </div>
+      `
+    })
+    class DeferComp {
+    }
+
+    TestBed.configureTestingModule({
+      imports: [
+        DeferComp,
+        SecondDeferredComp,
+      ],
+      providers: COMMON_PROVIDERS,
+      deferBlockBehavior: DeferBlockBehavior.Manual,
+    });
+
+    const componentFixture = TestBed.createComponent(DeferComp);
+    const deferBlock = (await componentFixture.getDeferBlocks())[0];
+    const el = componentFixture.nativeElement as HTMLElement;
+    await deferBlock.render(DeferBlockState.Complete);
+    expect(el.querySelector('.more')).toBeDefined();
+  });
+
   it('should render a placeholder defer state', async () => {
     @Component({
       selector: 'defer-comp',

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,6 @@ export function assertDeferredDependenciesLoaded(tDetails: TDeferBlockDetails) {`
`141`	`141`	`* that a primary template exists. All the other template options are optional.`
`142`	`142`	`*/`
`143`	`143`	`export function isTDeferBlockDetails(value: unknown): value is TDeferBlockDetails {`
`144`		`- return (typeof value === 'object') &&`
	`144`	`+ return value !== null && (typeof value === 'object') &&`
`145`	`145`	`(typeof (value as TDeferBlockDetails).primaryTmplIndex === 'number');`
`146`	`146`	`}`