perf(platform-browser): do not remove renderer from cache when REMOVE_STYLES_ON_COMPONENT_DESTROY is enabled. (#51005)

alan-agius4 · dylhunn · commit 31419f6a3b7d · 2023-07-11T10:11:51.000-07:00
Removing the renderer from cache is not needed when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is enabled. This change retains the behaviour of keeping the renderer cached for the entire lifecycle of the application the same way it is done when `REMOVE_STYLES_ON_COMPONENT_DESTROY` is disabled. This seems to have be causing an increase in scripting. See: http://b/290666638 PR Close #51005
diff --git a/packages/platform-browser/src/dom/dom_renderer.ts b/packages/platform-browser/src/dom/dom_renderer.ts
@@ -132,7 +132,6 @@ export class DomRendererFactory2 implements RendererFactory2, OnDestroy {
           break;
       }
 
-      renderer.onDestroy = () => rendererByCompId.delete(type.id);
       rendererByCompId.set(type.id, renderer);
     }
 
@@ -397,8 +396,6 @@ class ShadowDomRenderer extends DefaultDomRenderer2 {
 
 class NoneEncapsulationDomRenderer extends DefaultDomRenderer2 {
   private readonly styles: string[];
-  private rendererUsageCount = 0;
-  onDestroy: VoidFunction|undefined;
 
   constructor(
       eventManager: EventManager,
@@ -416,7 +413,6 @@ class NoneEncapsulationDomRenderer extends DefaultDomRenderer2 {
 
   applyStyles(): void {
     this.sharedStylesHost.addStyles(this.styles);
-    this.rendererUsageCount++;
   }
 
   override destroy(): void {
@@ -425,10 +421,6 @@ class NoneEncapsulationDomRenderer extends DefaultDomRenderer2 {
     }
 
     this.sharedStylesHost.removeStyles(this.styles);
-    this.rendererUsageCount--;
-    if (this.rendererUsageCount === 0) {
-      this.onDestroy?.();
-    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,6 @@ export class DomRendererFactory2 implements RendererFactory2, OnDestroy {`
`132`	`132`	`break;`
`133`	`133`	`}`
`134`	`134`
`135`		`- renderer.onDestroy = () => rendererByCompId.delete(type.id);`
`136`	`135`	`rendererByCompId.set(type.id, renderer);`
`137`	`136`	`}`
`138`	`137`
`@@ -397,8 +396,6 @@ class ShadowDomRenderer extends DefaultDomRenderer2 {`
`397`	`396`
`398`	`397`	`class NoneEncapsulationDomRenderer extends DefaultDomRenderer2 {`
`399`	`398`	`private readonly styles: string[];`
`400`		`- private rendererUsageCount = 0;`
`401`		`- onDestroy: VoidFunction\|undefined;`
`402`	`399`
`403`	`400`	`constructor(`
`404`	`401`	`eventManager: EventManager,`
`@@ -416,7 +413,6 @@ class NoneEncapsulationDomRenderer extends DefaultDomRenderer2 {`
`416`	`413`
`417`	`414`	`applyStyles(): void {`
`418`	`415`	`this.sharedStylesHost.addStyles(this.styles);`
`419`		`- this.rendererUsageCount++;`
`420`	`416`	`}`
`421`	`417`
`422`	`418`	`override destroy(): void {`
`@@ -425,10 +421,6 @@ class NoneEncapsulationDomRenderer extends DefaultDomRenderer2 {`
`425`	`421`	`}`
`426`	`422`
`427`	`423`	`this.sharedStylesHost.removeStyles(this.styles);`
`428`		`- this.rendererUsageCount--;`
`429`		`- if (this.rendererUsageCount === 0) {`
`430`		`- this.onDestroy?.();`
`431`		`- }`
`432`	`424`	`}`
`433`	`425`	`}`
`434`	`426`