fix(core): cleanup rxResource abort listener (#58306)

arturovt · thePunderWoman · commit 2b1b14f4d375 · 2025-05-21T15:17:24.000Z
The observable terminates immediately when `error` is called, and no further emissions or completion notifications occur. Thus, we have to remove the `abort` listener in both the `error` and `complete` notifications. PR Close #58306
diff --git a/packages/common/http/src/resource.ts b/packages/common/http/src/resource.ts
@@ -364,6 +364,7 @@ class HttpResourceImpl<T>
             }
 
             send({error});
+            abortSignal.removeEventListener('abort', onAbort);
           },
           complete: () => {
             if (resolve) {
diff --git a/packages/core/rxjs-interop/src/rx_resource.ts b/packages/core/rxjs-interop/src/rx_resource.ts
@@ -69,7 +69,10 @@ export function rxResource<T, R>(opts: RxResourceOptions<T, R>): ResourceRef<T |
 
       sub = opts.loader(params).subscribe({
         next: (value) => send({value}),
-        error: (error) => send({error}),
+        error: (error) => {
+          send({error});
+          params.abortSignal.removeEventListener('abort', onAbort);
+        },
         complete: () => {
           if (resolve) {
             send({error: new Error('Resource completed before producing a value')});

Original file line number	Diff line number	Diff line change
`@@ -364,6 +364,7 @@ class HttpResourceImpl<T>`
`364`	`364`	`}`
`365`	`365`
`366`	`366`	`send({error});`
	`367`	`+ abortSignal.removeEventListener('abort', onAbort);`
`367`	`368`	`},`
`368`	`369`	`complete: () => {`
`369`	`370`	`if (resolve) {`