refactor(platform-browser-dynamic): relocate DOMTestComponentRenderer to @angular/platform-browser (#60453)

alan-agius4 · pkozlowski-opensource · commit 2466fc9b4207 · 2025-03-19T19:08:09.000+01:00
This commit moves `DOMTestComponentRenderer` to `@angular/platform-browser/testing`, allowing the Angular CLI to eliminate its dependency on `@angular/platform-browser-dynamic`, which would no longer be required for new projects. PR Close #60453
diff --git a/goldens/public-api/platform-browser-dynamic/index.api.md b/goldens/public-api/platform-browser-dynamic/index.api.md
@@ -4,10 +4,10 @@
 
 ```ts
 
+import * as _angular_core from '@angular/core';
 import { Compiler } from '@angular/core';
 import { CompilerFactory } from '@angular/core';
 import { CompilerOptions } from '@angular/core';
-import * as i0 from '@angular/core';
 import { Version } from '@angular/core';
 
 // @public @deprecated (undocumented)
@@ -17,7 +17,7 @@ export class JitCompilerFactory implements CompilerFactory {
 }
 
 // @public (undocumented)
-export const platformBrowserDynamic: (extraProviders?: i0.StaticProvider[]) => i0.PlatformRef;
+export const platformBrowserDynamic: (extraProviders?: _angular_core.StaticProvider[]) => _angular_core.PlatformRef;
 
 // @public (undocumented)
 export const VERSION: Version;
diff --git a/goldens/public-api/platform-browser-dynamic/testing/index.api.md b/goldens/public-api/platform-browser-dynamic/testing/index.api.md
@@ -4,19 +4,19 @@
 
 ```ts
 
-import * as i0 from '@angular/core';
+import * as _angular_core from '@angular/core';
 import * as i1 from '@angular/platform-browser/testing';
 import { PlatformRef } from '@angular/core';
 import { StaticProvider } from '@angular/core';
 
 // @public
 export class BrowserDynamicTestingModule {
     // (undocumented)
-    static ɵfac: i0.ɵɵFactoryDeclaration<BrowserDynamicTestingModule, never>;
+    static ɵfac: _angular_core.ɵɵFactoryDeclaration<BrowserDynamicTestingModule, never>;
     // (undocumented)
-    static ɵinj: i0.ɵɵInjectorDeclaration<BrowserDynamicTestingModule>;
+    static ɵinj: _angular_core.ɵɵInjectorDeclaration<BrowserDynamicTestingModule>;
     // (undocumented)
-    static ɵmod: i0.ɵɵNgModuleDeclaration<BrowserDynamicTestingModule, never, never, [typeof i1.BrowserTestingModule]>;
+    static ɵmod: _angular_core.ɵɵNgModuleDeclaration<BrowserDynamicTestingModule, never, never, [typeof i1.BrowserTestingModule]>;
 }
 
 // @public (undocumented)
diff --git a/packages/core/testing/src/test_bed_compiler.ts b/packages/core/testing/src/test_bed_compiler.ts
@@ -989,7 +989,7 @@ export class TestBedCompiler {
     }
 
     const providers: StaticProvider[] = [];
-    const compilerOptions = this.platform.injector.get(COMPILER_OPTIONS);
+    const compilerOptions = this.platform.injector.get(COMPILER_OPTIONS, []);
     compilerOptions.forEach((opts) => {
       if (opts.providers) {
         providers.push(opts.providers);
diff --git a/packages/platform-browser-dynamic/testing/src/private_export_testing.ts b/packages/platform-browser-dynamic/testing/src/private_export_testing.ts
@@ -6,5 +6,5 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-export {DOMTestComponentRenderer as ɵDOMTestComponentRenderer} from './dom_test_component_renderer';
 export {platformCoreDynamicTesting as ɵplatformCoreDynamicTesting} from './platform_core_dynamic_testing';
+export {ɵDOMTestComponentRenderer} from '@angular/platform-browser/testing';
diff --git a/packages/platform-browser-dynamic/testing/src/testing.ts b/packages/platform-browser-dynamic/testing/src/testing.ts
@@ -7,11 +7,9 @@
  */
 
 import {createPlatformFactory, NgModule, PlatformRef, StaticProvider} from '@angular/core';
-import {TestComponentRenderer} from '@angular/core/testing';
 import {ɵINTERNAL_BROWSER_DYNAMIC_PLATFORM_PROVIDERS as INTERNAL_BROWSER_DYNAMIC_PLATFORM_PROVIDERS} from '@angular/platform-browser-dynamic';
 import {BrowserTestingModule} from '@angular/platform-browser/testing';
 
-import {DOMTestComponentRenderer} from './dom_test_component_renderer';
 import {platformCoreDynamicTesting} from './platform_core_dynamic_testing';
 
 export * from './private_export_testing';
@@ -32,6 +30,5 @@ export const platformBrowserDynamicTesting = createPlatformFactory(
  */
 @NgModule({
   exports: [BrowserTestingModule],
-  providers: [{provide: TestComponentRenderer, useClass: DOMTestComponentRenderer}],
 })
 export class BrowserDynamicTestingModule {}
diff --git a/packages/platform-browser/testing/src/browser.ts b/packages/platform-browser/testing/src/browser.ts
@@ -18,7 +18,9 @@ import {
   ɵChangeDetectionScheduler as ChangeDetectionScheduler,
   ɵChangeDetectionSchedulerImpl as ChangeDetectionSchedulerImpl,
 } from '@angular/core';
+import {TestComponentRenderer} from '@angular/core/testing';
 import {BrowserModule, ɵBrowserDomAdapter as BrowserDomAdapter} from '@angular/platform-browser';
+import {DOMTestComponentRenderer} from './dom_test_component_renderer';
 
 function initBrowserTests() {
   BrowserDomAdapter.makeCurrent();
@@ -51,6 +53,7 @@ export const platformBrowserTesting = createPlatformFactory(
     internalProvideZoneChangeDetection({}),
     {provide: ChangeDetectionScheduler, useExisting: ChangeDetectionSchedulerImpl},
     {provide: PlatformLocation, useClass: MockPlatformLocation},
+    {provide: TestComponentRenderer, useClass: DOMTestComponentRenderer},
   ],
 })
 export class BrowserTestingModule {}
diff --git a/packages/platform-browser/testing/src/dom_test_component_renderer.ts b/packages/platform-browser/testing/src/dom_test_component_renderer.ts
diff --git a/packages/platform-browser/testing/src/private_export_testing.ts b/packages/platform-browser/testing/src/private_export_testing.ts
@@ -0,0 +1,9 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.dev/license
+ */
+
+export {DOMTestComponentRenderer as ɵDOMTestComponentRenderer} from './dom_test_component_renderer';
diff --git a/packages/platform-browser/testing/src/testing.ts b/packages/platform-browser/testing/src/testing.ts
@@ -12,3 +12,4 @@
  * Entry point for all public APIs of the platform-browser/testing package.
  */
 export * from './browser';
+export * from './private_export_testing';

Original file line number	Diff line number	Diff line change
`@@ -989,7 +989,7 @@ export class TestBedCompiler {`
`989`	`989`	`}`
`990`	`990`
`991`	`991`	`const providers: StaticProvider[] = [];`
`992`		`- const compilerOptions = this.platform.injector.get(COMPILER_OPTIONS);`
	`992`	`+ const compilerOptions = this.platform.injector.get(COMPILER_OPTIONS, []);`
`993`	`993`	`compilerOptions.forEach((opts) => {`
`994`	`994`	`if (opts.providers) {`
`995`	`995`	`providers.push(opts.providers);`