refactor(core): Cleanup dead jsnamespace code (#55795)

rahatarmanahmed · dylhunn · commit 239d4f0c9ea7 · 2024-05-17T12:59:41.000-07:00
Support for the jsnamespace attribute was removed in #55619. PR Close #55795
diff --git a/packages/core/primitives/event-dispatch/src/attribute.ts b/packages/core/primitives/event-dispatch/src/attribute.ts
@@ -14,24 +14,12 @@
  * an optional DOM event name and a jsaction name. If the optional
  * DOM event name is omitted, 'click' is assumed. The jsaction names
  * are dot separated pairs of a namespace and a simple jsaction
- * name. If the namespace is absent, it is taken from the closest
- * ancestor element with a jsnamespace attribute, if there is
- * any. If there is no ancestor with a jsnamespace attribute, the
- * simple name is assumed to be the jsaction name.
+ * name.
  *
- * Used by EventContract.
+ * See grammar in README.md for expected syntax in the attribute value.
  */
 export const JSACTION = 'jsaction';
 
-/**
- * The jsnamespace attribute provides the namespace part of the
- * jaction names occurring in the jsaction attribute where it's
- * missing.
- *
- * Used by EventContract.
- */
-export const JSNAMESPACE = 'jsnamespace';
-
 /**
  * The oi attribute is a log impression tag for impression logging
  * and action tracking. For an element that carries a jsaction
@@ -74,4 +62,4 @@ export const JSINSTANCE = 'jsinstance';
  */
 export const JSTRACK = 'jstrack';
 
-export const Attribute = {JSACTION, JSNAMESPACE, OI, VED, VET, JSINSTANCE, JSTRACK};
+export const Attribute = {JSACTION, OI, VED, VET, JSINSTANCE, JSTRACK};
diff --git a/packages/core/primitives/event-dispatch/src/cache.ts b/packages/core/primitives/event-dispatch/src/cache.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {JSACTION, JSNAMESPACE} from './property';
+import {JSACTION} from './property';
 
 /**
  * Map from jsaction annotation to a parsed map from event name to action name.
@@ -66,39 +66,3 @@ export function clear(element: Element) {
     delete element[JSACTION];
   }
 }
-
-/**
- * Reads the cached jsaction namespace from the given DOM
- * Element. Undefined means there is no cached value; null is a cached
- * jsnamespace attribute that's absent.
- *
- * @param element .
- * @return .
- */
-export function getNamespace(element: Element): string | null | undefined {
-  // @ts-ignore
-  return element[JSNAMESPACE];
-}
-
-/**
- * Writes the cached jsaction namespace to the given DOM Element. Null
- * represents a jsnamespace attribute that's absent.
- *
- * @param element .
- * @param jsnamespace .
- */
-export function setNamespace(element: Element, jsnamespace: string | null) {
-  // @ts-ignore
-  element[JSNAMESPACE] = jsnamespace;
-}
-
-/**
- * Clears the cached jsaction namespace from the given DOM Element.
- *
- * @param element .
- */
-export function clearNamespace(element: Element) {
-  if (JSNAMESPACE in element) {
-    delete element[JSNAMESPACE];
-  }
-}
diff --git a/packages/core/primitives/event-dispatch/src/property.ts b/packages/core/primitives/event-dispatch/src/property.ts
@@ -16,12 +16,6 @@
  */
 export const JSACTION = '__jsaction';
 
-/**
- * The parsed value of the jsnamespace attribute is stored in this
- * property on the DOM node.
- */
-export const JSNAMESPACE = '__jsnamespace';
-
 /** The value of the oi attribute as a property, for faster access. */
 export const OI = '__oi';
 
@@ -36,15 +30,13 @@ export const OWNER = '__owner';
 /** All properties that are used by jsaction. */
 export const Property = {
   JSACTION,
-  JSNAMESPACE,
   OI,
   OWNER,
 };
 
 declare global {
   interface Node {
     [JSACTION]?: string;
-    [JSNAMESPACE]?: string;
     [OI]?: string;
     [OWNER]?: ParentNode;
   }
diff --git a/packages/core/primitives/event-dispatch/test/eventcontract_test.ts b/packages/core/primitives/event-dispatch/test/eventcontract_test.ts
@@ -180,13 +180,6 @@ const domContent = `
   </div>
 </div>
 
-<div id="jsnamespace-container">
-  <div id="jsnamespace-namespace-element" jsnamespace="namespace">
-    <div id="jsnamespace-action-element" jsaction="handleClick">
-      <div id="jsnamespace-target-element"></div>
-    </div>
-  </div>
-</div>
 <div id="focus-container">
   <div id="focus-action-element" jsaction="focus:handleFocus">
     <button id="focus-target-element">Focus Button</button>
