fix(router): Clear internal transition when navigation finalizes (#54261)

atscott · thePunderWoman · commit 238f2a8bc9c4 · 2024-02-06T20:32:34.000Z
This commit fixes a small memory issue in the router where a destroyed component instance would be retained. fixes #54241 PR Close #54261
diff --git a/packages/router/src/navigation_transition.ts b/packages/router/src/navigation_transition.ts
@@ -688,6 +688,7 @@ export class NavigationTransitions {
                            // finalized.
                            if (this.currentNavigation?.id === overallTransitionState.id) {
                              this.currentNavigation = null;
+                             this.currentTransition = null;
                            }
                          }),
                          catchError((e) => {

Original file line number	Diff line number	Diff line change
`@@ -688,6 +688,7 @@ export class NavigationTransitions {`
`688`	`688`	`// finalized.`
`689`	`689`	`if (this.currentNavigation?.id === overallTransitionState.id) {`
`690`	`690`	`this.currentNavigation = null;`
	`691`	`+ this.currentTransition = null;`
`691`	`692`	`}`
`692`	`693`	`}),`
`693`	`694`	`catchError((e) => {`