refactor(core): Switch to using concat rather than spread operator for events. (#57103)

tbondwilkinson · atscott · commit 1a606b0bfcb5 · 2024-07-23T15:54:23.000-07:00
Internally, the JSCompiler does not dead code eliminate this code when its using spread. PR Close #57103
diff --git a/packages/core/primitives/event-dispatch/src/event_type.ts b/packages/core/primitives/event-dispatch/src/event_type.ts
@@ -372,7 +372,7 @@ export const isCaptureEventType = (eventType: string) =>
   CAPTURE_EVENT_TYPES.indexOf(eventType) >= 0;
 
 /** All event types that are registered early.  */
-const EARLY_EVENT_TYPES = [...BUBBLE_EVENT_TYPES, ...CAPTURE_EVENT_TYPES];
+const EARLY_EVENT_TYPES = BUBBLE_EVENT_TYPES.concat(CAPTURE_EVENT_TYPES);
 
 /**
  * Whether or not an event type is registered in the early contract.
diff --git a/packages/core/test/bundling/defer/bundle.golden_symbols.json b/packages/core/test/bundling/defer/bundle.golden_symbols.json
@@ -206,9 +206,6 @@
   {
     "name": "EventManagerPlugin"
   },
-  {
-    "name": "EventType"
-  },
   {
     "name": "GLOBAL_EVENT_DELEGATION"
   },

Original file line number	Diff line number	Diff line change
`@@ -206,9 +206,6 @@`
`206`	`206`	`{`
`207`	`207`	`"name": "EventManagerPlugin"`
`208`	`208`	`},`
`209`		`- {`
`210`		`- "name": "EventType"`
`211`		`- },`
`212`	`209`	`{`
`213`	`210`	`"name": "GLOBAL_EVENT_DELEGATION"`
`214`	`211`	`},`