Revert "feat(common): Support of optional keys for the KeyValue pipe (#48814)" (#64179)

kirjs · kirjs · commit 05370837fcd5 · 2025-10-01T12:45:32.000-04:00
This reverts commit 99c5269. PR Close #64179
diff --git a/goldens/public-api/common/index.api.md b/goldens/public-api/common/index.api.md
@@ -390,8 +390,6 @@ export class KeyValuePipe implements PipeTransform {
     // (undocumented)
     transform<K extends string, V>(input: Record<K, V> | ReadonlyMap<K, V> | null | undefined, compareFn?: ((a: KeyValue<K, V>, b: KeyValue<K, V>) => number) | null): Array<KeyValue<K, V>> | null;
     // (undocumented)
-    transform<T, K extends keyof T>(input: T, compareFn?: (a: T[K], b: T[K]) => number): T extends null ? null : Array<T[K]>;
-    // (undocumented)
     static ɵfac: i0.ɵɵFactoryDeclaration<KeyValuePipe, never>;
     // (undocumented)
     static ɵpipe: i0.ɵɵPipeDeclaration<KeyValuePipe, "keyvalue", true>;
diff --git a/packages/common/src/pipes/keyvalue_pipe.ts b/packages/common/src/pipes/keyvalue_pipe.ts
@@ -96,10 +96,6 @@ export class KeyValuePipe implements PipeTransform {
     input: Record<K, V> | ReadonlyMap<K, V> | null | undefined,
     compareFn?: ((a: KeyValue<K, V>, b: KeyValue<K, V>) => number) | null,
   ): Array<KeyValue<K, V>> | null;
-  transform<T, K extends keyof T>(
-    input: T,
-    compareFn?: (a: T[K], b: T[K]) => number,
-  ): T extends null ? null : Array<T[K]>;
   transform<K, V>(
     input: undefined | null | {[key: string]: V; [key: number]: V} | ReadonlyMap<K, V>,
     compareFn: ((a: KeyValue<K, V>, b: KeyValue<K, V>) => number) | null = defaultComparator,
diff --git a/packages/common/test/pipes/keyvalue_pipe_spec.ts b/packages/common/test/pipes/keyvalue_pipe_spec.ts
@@ -99,41 +99,6 @@ describe('KeyValuePipe', () => {
       const pipe = new KeyValuePipe(defaultKeyValueDiffers);
       expect(pipe.transform(value)).toEqual(null);
     });
-
-    it('should accept an object with optional keys', () => {
-      interface MyInterface {
-        one: string;
-        two: number;
-        three: string;
-        four: string;
-      }
-      const myData: Partial<MyInterface> = {
-        one: 'One',
-        two: 2,
-        three: undefined,
-      };
-
-      const pipe = new KeyValuePipe(defaultKeyValueDiffers);
-      expect(pipe.transform(myData)?.length).toEqual(3);
-
-      const differ = (a: string | number | undefined, b: string | number | undefined): number => {
-        return 1;
-      };
-      expect(pipe.transform(myData, differ)?.length).toEqual(3);
-    });
-
-    it('should accept an nullable object with optional keys', () => {
-      interface MyInterface {
-        one?: string;
-        two?: string;
-        three?: string;
-      }
-
-      let value!: MyInterface | null;
-      const pipe = new KeyValuePipe(defaultKeyValueDiffers);
-      // If null what not supported by this signature we would have gotten a never[] back.
-      expect(pipe.transform(value)).toEqual(null);
-    });
   });
 
   describe('Map', () => {
