fix(core): TestBed should not override NgZone from initTestEnvironment (#55226)

atscott · AndrewKushnir · commit 0510930a257e · 2024-05-06T13:33:17.000-07:00
Prior to this change, `NgZone` was provided by default in TestBed in a location that would override anything configured in `TestBed.initTestEnvironment`. This change moves the default `NgZone` provider to the `RootScopeModule` and these providers can be overridden by the ones in `additionalModuleTypes`, which are assigned from the first argument of `initTestEnvironment`. This makes it possible to configure Zone globally for all tests as opposed to needing to repeat it in `configureTestingModule` of each suite. PR Close #55226
diff --git a/packages/core/testing/src/test_bed_compiler.ts b/packages/core/testing/src/test_bed_compiler.ts
@@ -927,11 +927,10 @@ export class TestBedCompiler {
   private compileTestModule(): void {
     class RootScopeModule {}
     compileNgModuleDefs(RootScopeModule as NgModuleType<any>, {
-      providers: [...this.rootProviderOverrides],
+      providers: [...this.rootProviderOverrides, provideZoneChangeDetection()],
     });
 
     const providers = [
-      provideZoneChangeDetection(),
       {provide: Compiler, useFactory: () => new R3TestCompiler(this)},
       {provide: DEFER_BLOCK_CONFIG, useValue: {behavior: this.deferBlockBehavior}},
       ...this.providers,
