fix(compiler-cli): handle enum members without initializers in partial evaluator (#59815)

crisbeto · alxhub · commit 03bcd30e3487 · 2025-02-03T13:58:31.000-08:00
Fixes that the partial evaluator was interpreting initializer-less enum members as undefined. In this case the value is the same as the index. PR Close #59815
diff --git a/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts b/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts
@@ -314,10 +314,10 @@ export class StaticInterpreter {
   private visitEnumDeclaration(node: ts.EnumDeclaration, context: Context): ResolvedValue {
     const enumRef = this.getReference(node, context);
     const map = new Map<string, EnumValue>();
-    node.members.forEach((member) => {
+    node.members.forEach((member, index) => {
       const name = this.stringNameFromPropertyName(member.name, context);
       if (name !== undefined) {
-        const resolved = member.initializer && this.visit(member.initializer, context);
+        const resolved = member.initializer ? this.visit(member.initializer, context) : index;
         map.set(name, new EnumValue(enumRef, name, resolved));
       }
     });
diff --git a/packages/compiler-cli/src/ngtsc/partial_evaluator/test/evaluator_spec.ts b/packages/compiler-cli/src/ngtsc/partial_evaluator/test/evaluator_spec.ts
@@ -638,6 +638,7 @@ runInEachFileSystem(() => {
       }
       expect((result.enumRef.node as ts.EnumDeclaration).name.text).toBe('Foo');
       expect(result.name).toBe('B');
+      expect(result.resolved).toBe(1);
     });
 
     it('variable declaration resolution works', () => {

Original file line number	Diff line number	Diff line change
`@@ -638,6 +638,7 @@ runInEachFileSystem(() => {`
`638`	`638`	`}`
`639`	`639`	`expect((result.enumRef.node as ts.EnumDeclaration).name.text).toBe('Foo');`
`640`	`640`	`expect(result.name).toBe('B');`
	`641`	`+ expect(result.resolved).toBe(1);`
`641`	`642`	`});`
`642`	`643`
`643`	`644`	`it('variable declaration resolution works', () => {`