Async slicing vector proto#23
Merged
andy-sweet merged 19 commits intoandy-sweet:async-slice-protofrom Sep 2, 2022
Merged
Conversation
Author
|
I'm not sure how much further to take this. I could continue but then I feel like I'd just be writing the "real" code. |
kcpevey
commented
Aug 26, 2022
|
|
||
| self.reset() | ||
| self._on_data_change() | ||
| # self._on_data_change() |
Author
There was a problem hiding this comment.
This needs to be addressed, along with line 17.
Author
There was a problem hiding this comment.
I've uncommented the on_data_change to allow some methods to function (edge_color changes). There is still an open question of how we will handle these events that don't require an entire reslice event. I think there may be a reasonable path forward with the SliceInput/Output state implementation.
kcpevey
commented
Aug 26, 2022
kcpevey
commented
Aug 26, 2022
kcpevey
commented
Aug 26, 2022
…c_slicing_vector_proto
andy-sweet
reviewed
Aug 26, 2022
andy-sweet
reviewed
Aug 26, 2022
andy-sweet
approved these changes
Sep 2, 2022
Owner
andy-sweet
left a comment
There was a problem hiding this comment.
Looks good to me. I'll merge this in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement vector async slicing
Type of change
References
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.to make them localizable.For more information see our translations guide.