Skip to content
This repository was archived by the owner on Dec 27, 2024. It is now read-only.

fix relative motion support#632

Merged
jafu888 merged 5 commits intomainfrom
release_5_19
Jun 17, 2022
Merged

fix relative motion support#632
jafu888 merged 5 commits intomainfrom
release_5_19

Conversation

@jafu888
Copy link
Copy Markdown
Contributor

@jafu888 jafu888 commented Jun 16, 2022

Still need cleanup and
image
more testing

@jafu888 jafu888 requested a review from oscar-ad June 16, 2022 05:16
@jafu888
Copy link
Copy Markdown
Contributor Author

jafu888 commented Jun 16, 2022

Now circular: ['box1', 900, 70],
Now setting high rotations can be use to influence animation
https://user-images.githubusercontent.com/15019413/174113813-b39e294c-f6f2-41af-9a92-034c3271cbc8.mp4

@jafu888 jafu888 requested a review from camaelon June 17, 2022 03:21
oscar-ad
oscar-ad suggested changes Jun 17, 2022
View reviewed changes
constraintlayout/core/src/main/java/androidx/constraintlayout/core/motion/Motion.java

public void setIdString(String stringId) {
mId = stringId;
mStartMotionPath.mId = mId;
Copy link
Copy Markdown
Contributor

@oscar-ad oscar-ad Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about mEndMotionPath.mId = mId?
Is it not relevant there?

@jswong65
Copy link
Copy Markdown
Contributor

jswong65 commented Jun 17, 2022

Core / Assemble checks failed. Could you please fix it

/home/runner/work/constraintlayout/constraintlayout/constraintlayout/core/src/main/java/androidx/constraintlayout/core/motion/Motion.java:34: error: cannot find symbol
import androidx.constraintlayout.core.motion.utils.Nullable;
> Task :core:compileJava
                                                  ^
  symbol:   class Nullable
  location: package androidx.constraintlayout.core.motion.utils
/home/runner/work/constraintlayout/constraintlayout/constraintlayout/core/src/main/java/androidx/constraintlayout/core/motion/Motion.java:241: error: cannot find symbol
    @Nullable
     ^
  symbol:   class Nullable
  location: class Motion

https://github.com/androidx/constraintlayout/runs/6941085866?check_suite_focus=true

@jafu888 jafu888 merged commit 1c79d64 into main Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@camaelon camaelon Awaiting requested review from camaelon

2 more reviewers

@oscar-ad oscar-ad oscar-ad requested changes

@jswong65 jswong65 jswong65 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jafu888 @jswong65 @oscar-ad