Skip to content

Make paging-testing multiplatform by moving everything to common*#609

Closed
veyndan wants to merge 3 commits intoandroidx:androidx-mainfrom
veyndan:paging-testing
Closed

Make paging-testing multiplatform by moving everything to common*#609
veyndan wants to merge 3 commits intoandroidx:androidx-mainfrom
veyndan:paging-testing

Conversation

@veyndan
Copy link
Copy Markdown
Contributor

@veyndan veyndan commented Sep 9, 2023

Test: ./gradlew paging:paging-testing:allTests

@veyndan veyndan requested review from dlam and yigit as code owners September 9, 2023 13:40
Comment thread paging/paging-testing/build.gradle
@veyndan
Copy link
Copy Markdown
Contributor Author

veyndan commented Sep 9, 2023

CI should be fixed by https://android-review.googlesource.com/c/platform/frameworks/support/+/2746657. I'll rebase this PR once that has been merged.

Copy link
Copy Markdown
Member

@claraf3 claraf3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@claraf3 claraf3 requested review from ianhanniballake and removed request for dlam and yigit September 11, 2023 17:52
@dlam
Copy link
Copy Markdown
Member

dlam commented Sep 11, 2023

Copybara is having trouble mirroring this because of the conflict.

@claraf3
Copy link
Copy Markdown
Member

claraf3 commented Sep 11, 2023

Infra recently upgraded their build and changed androidTest references to androidUnitTest. Can you please try rebasing?

@veyndan
Copy link
Copy Markdown
Contributor Author

veyndan commented Sep 11, 2023

Rebased!

@veyndan veyndan deleted the paging-testing branch September 11, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants