Presubmit is unhappy because there's no Test: stanza in the commit message.

Please update your PR message to use Bug: <bug-id> or Fixes: <bug-id> for the bug numbers addressed and Test: <class-name> for the test added, as in #428

@alanv Thanks for the reminder, the revision has been completed

Still needs a Test: stanza. Given that we're not adding LeakCanary to the CI tests, I think Test: manually ran with LeakCanary is appropriate.

Still needs a Test: stanza. Given that we're not adding LeakCanary to the CI tests, I think Test: manually ran with LeakCanary is appropriate.

@alanv Hello, I have made the modification here as required.

@liutikas @alanv Hello, what is the problem with the merge code?

@tikurahul @alanv @liutikas Hello, this problem seems to be difficult to solve, do I need to initiate a new pull request?

If @dlam and @tikurahul can't get this working, our GitHub workflow is busted. Let's keep pushing on this PR.

I added some additional logging in the check-pr-format-action. @getActivity Did you actually change the commit message to include the Test stanza as well ? GitHub lets you change it after you make the PR, but that does not change the underlying commit message. One thing that might help is to git commit --amend with the Test stanza and do a force push so the action is forced to pick up all the new changes.

@tikurahul Hello, I have modified the commit message as required, can you take a look again?

Kicking off another workflow run ! It moved past the point of last failure. So its promising 🤞🏽

@tikurahul Hello, I found a code check failure here, will this affect code merging?

@tikurahul Hello, I found a code check failure here, will this affect code merging?

> Task :core:core:lintDebug FAILED
/home/runner/work/androidx/androidx/core/core/src/main/java/androidx/core/app/ActivityCompat.java:830: Error: Calling Method.invoke without an SDK check [BanUncheckedReflection from androidx.build]
                return (boolean) method.invoke(packageManager, permission);
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "BanUncheckedReflection":
   Jetpack policy discourages reflection. In cases where reflection is used on
   platform SDK classes, it must be used within an SDK_INT check that
   delegates to an equivalent public API on the latest version of the
   platform. If no equivalent public API exists, reflection must not be used.

This is a real error that you need to fix. @alanv can probably advise on best way to go about it.

@alanv Hello, do you have any good advice on this issue?

@tikurahul @dlam @liutikas Do you guys have any good solutions?

@alanv @tikurahul @dlam @liutikas Hi, I see @SuppressLint("BanUncheckedReflection") is used in AndroidX code to suppress reflection warnings, can I add @SuppressLint("BanUncheckedReflection") to avoid this issue?

@alanv @tikurahul @dlam @liutikas Hi, I see @SuppressLint("BanUncheckedReflection") is used in AndroidX code to suppress reflection warnings, can I add @SuppressLint("BanUncheckedReflection") to avoid this issue?

Yes, this can be suppressed since the call site is wrapped with an SDK_INT check.

@alanv Hello, I have submitted the modification of this part of the code

@alanv Hello, please check whether there are any problems with the changes, if there are any, please point out, if not, please approve them