This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Implements @RootFragment annotation support. #2202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11aa5ee to
93ef3ed
Compare
dodgex
suggested changes
Feb 15, 2019
...re/androidannotations-api/src/main/java/org/androidannotations/annotations/RootFragment.java
Outdated
Show resolved
Hide resolved
...tations-core/androidannotations/src/main/java/org/androidannotations/holder/EBeanHolder.java
Show resolved
Hide resolved
...otations/src/main/java/org/androidannotations/internal/core/handler/RootFragmentHandler.java
Outdated
Show resolved
Hide resolved
93ef3ed to
6a485f0
Compare
WonderCsabo
suggested changes
Feb 15, 2019
Member
WonderCsabo
left a comment
There was a problem hiding this comment.
Please add compile time tests to verify validation and that correct code compiles, and runtime tests as well.
...re/androidannotations-api/src/main/java/org/androidannotations/annotations/RootFragment.java
Outdated
Show resolved
Hide resolved
...re/androidannotations-api/src/main/java/org/androidannotations/annotations/RootFragment.java
Outdated
Show resolved
Hide resolved
...tations-core/androidannotations/src/main/java/org/androidannotations/holder/EBeanHolder.java
Outdated
Show resolved
Hide resolved
...tations-core/androidannotations/src/main/java/org/androidannotations/holder/EBeanHolder.java
Outdated
Show resolved
Hide resolved
...otations/src/main/java/org/androidannotations/internal/core/handler/RootFragmentHandler.java
Show resolved
Hide resolved
This was referenced Feb 15, 2019
c79722f to
02c0b61
Compare
WonderCsabo
suggested changes
Feb 16, 2019
Member
WonderCsabo
left a comment
There was a problem hiding this comment.
Thanks for adding the extensive tests! I added some small review comments.
...e/androidannotations/src/test/java/org/androidannotations/rootfragment/RootFragmentTest.java
Show resolved
Hide resolved
...nnotations-testutils/src/main/java/org/androidannotations/testutils/ProcessorTestHelper.java
Show resolved
Hide resolved
...nnotations-test/src/test/java/org/androidannotations/test/rootfragment/RootFragmentTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/androidannotations/test/rootfragment/ActivityWithBeansWithRootFragment.java
Outdated
Show resolved
Hide resolved
...ore/androidannotations/src/test/java/org/androidannotations/rootfragment/CustomFragment.java
Outdated
Show resolved
Hide resolved
WonderCsabo
reviewed
Feb 16, 2019
...tations-core/androidannotations/src/main/java/org/androidannotations/holder/EBeanHolder.java
Show resolved
Hide resolved
a7907e6 to
7f374b9
Compare
Contributor
Author
|
@WonderCsabo Travis failed this time but seems to be due to some missing copyrights in some other files |
Contributor
Author
|
I will add them.. |
7f374b9 to
8738fce
Compare
Member
|
Thanks, that was my fault. I forgot to rebase the branch to include the license check... |
Member
|
BTW, next time please create separate commits for unrelated changes such as this. |
WonderCsabo
previously approved these changes
Feb 17, 2019
4da9e81 to
6e5afd6
Compare
Member
|
This depends on #2211 , right? |
Contributor
Author
|
Right now yes 😅 |
Member
|
#2211 has been merged. |
Contributor
Author
|
I will rebase this branch, to simplify its revision. |
Member
|
@smaugho please rebase this. |
6e5afd6 to
8efbb50
Compare
Contributor
Author
|
Done |
WonderCsabo
approved these changes
Feb 22, 2019
dodgex
approved these changes
Feb 22, 2019
Member
|
Thanks! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented the support for a
@RootFragmentwhich solves the issue #1636 . Please let me know about any question/suggestion regarding the solution.Thanks.