This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Fix logging and prevent similar issues #2148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The build fails due to invalid license header as i already used 2018 but the plugin checks for 2017 until #2142 is merged. |
Member
Author
|
This needs to be merged BEFORE #2146 as there is a new log statement that needs to be updated to the changes of this PR |
WonderCsabo
previously approved these changes
Jun 20, 2018
WonderCsabo
approved these changes
Jun 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix the logging issue mentioned in #2145 and prevent similar misuse in the future.
While the only place where this issue actually hapened where two
trace()statements inModelProcessorI refactored the log methods to have themessageargument last or second to last if there areargsallowed.