This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Fix IllegalStateException for @OrmLiteDao in view #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonderCsabo
commented
Oct 31, 2017
| case OnAttachOnDetach: | ||
| registerBlock = holder.getOnAttachAfterSuperBlock(); | ||
| unregisterBlock = holder.getOnDetachBeforeSuperBlock(); | ||
|
|
Member
Author
There was a problem hiding this comment.
This code is now rather ugly, but this is the price for removing the invalid abstraction HasLifecycleMethods. Do you have a better idea? @dodgex
Member
There was a problem hiding this comment.
Currently i cant think of a better way to solve this. :/
bc8aba4 to
86cc04f
Compare
dodgex
previously approved these changes
Oct 31, 2017
Member
dodgex
left a comment
There was a problem hiding this comment.
Beside the one unnecessary new line i think this is okay. If you do not want to update the pr for that space i'm okay with that. :D
| return getInitBodyInjectionBlock(); | ||
| } | ||
|
|
||
|
|
| case OnAttachOnDetach: | ||
| registerBlock = holder.getOnAttachAfterSuperBlock(); | ||
| unregisterBlock = holder.getOnDetachBeforeSuperBlock(); | ||
|
|
Member
There was a problem hiding this comment.
Currently i cant think of a better way to solve this. :/
androidannotations#2048 This commit contains a bigger refactor as well: the previous implementation contained HasLifecycleMethods interface, which was implemented by most all the components, even if they do not have the specific methods. This is now changed.
86cc04f to
bed7344
Compare
dodgex
approved these changes
Nov 1, 2017
Member
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2048
This commit contains a bigger refactor as well: the previous
implementation contained HasLifecycleMethods interface, which was
implemented by most all the components, even if they do not have
the specific methods. This is now changed.