Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Log tags need to be shorter than 24 chars according to android docume… #1739

Closed
ghost wants to merge 3 commits into from
Closed

Log tags need to be shorter than 24 chars according to android docume… #1739

ghost wants to merge 3 commits into from

Conversation

@ghost
Copy link

@ghost ghost commented Mar 30, 2016

@WonderCsabo
Copy link
Member

WonderCsabo commented Mar 30, 2016

Thanks for this PR! We have the same problem in TransactionalHandler and OrmLiteDaoHandler? Can you fix those as well? And maybe you can extract this into a helper class as well for example LogHelper.

@ghost
Copy link
Author

ghost commented Mar 30, 2016

@WonderCsabo bump

@WonderCsabo
Copy link
Member

WonderCsabo commented Apr 3, 2016

Thanks! Can i ask you to:

  • fix the header in the new class (the build is failed because of that)
  • please reword your commit messages per the contributor guide in the wiki
  • add an overload to the log helper method, which accepts a GeneratedClassHolder (so we can remove more code duplication)
  • squash the last commits

@WonderCsabo
Copy link
Member

WonderCsabo commented Apr 12, 2016

@delta2wye can you update the PR?

@dodgex dodgex mentioned this pull request Jun 1, 2016
Merged
@WonderCsabo WonderCsabo closed this Jun 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WonderCsabo @delta2wye