-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix in order parameter validation #1561
Fix in order parameter validation #1561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing test scope!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover, we use Mockito in other modules as well. So you can pull it to the root POM in dependencyManagement, just like we do with JUnit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
The test suite is far from full coverage, but it is a good start. Thanks for this PR, we really needed this fix, and we can move on. It seems Travis is down, so that is why it did not tell you have lots of Checkstyle errors in the test class and a missing licence header. Please fix this, as well as my other comments. After it, the PR can be merged. |
|
We have a problem: The problem here that |
9f3caee to
096b087
Compare
|
I addressed your comments. |
|
@yDelouis sure i'm okay with that. Thanks :) |
|
@yDelouis i just saw the |
|
@yDelouis also please rebase this so the build can go green. |
|
@yDelouis any update on this? |
Fixes #1443.