Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Conversation

@amatsegor
Copy link
Contributor

Fix of an assignment of the parameter to itself instead of the class field.

@WonderCsabo
Copy link
Member

Nice catch! Thanks. This line was broken by 2ee251d#diff-d29654a60dfa65217895cded5ca1943eR50. This property is not used currently, but would cause troubles in the future.

BTW, can you ask you to reword the commit as to add a more descriptive commit message per the contribution guidelines? Also, next time please use a proper branch name! (I know you just edited the file with the GitHub editor now.)

@amatsegor
Copy link
Contributor Author

Yep, you're right) Visited your project repo for the first time, chose a random file just to see how the framework works, found the problem and fixed it)
I'm a bit lazy to fork a repo for fixing such a small issue, but promise to do this next time :)

@WonderCsabo
Copy link
Member

Yeah, thanks for keeping to the boy scout rule! We welcome any contributions, from a typo fix to a big refactor.

No worries, and thanks! ;)

@WonderCsabo
Copy link
Member

Can you rebase this branch onto develop?

@WonderCsabo WonderCsabo reopened this Sep 11, 2015
@WonderCsabo
Copy link
Member

Merged as of 314fbec.

@WonderCsabo WonderCsabo added this to the 4.0 milestone Sep 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants