This repository was archived by the owner on Feb 26, 2023. It is now read-only.
getRootUrl support #602
Merged
getRootUrl support #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You also have to :
AndroidAnnotations/androidannotations/src/test/java/org/androidannotations/rest/RestTest.java : @Test
public void client_with_wrong_enhanced_methods() throws IOException {
CompileResult result = compileFiles(ClientWithWrongEnhancedMethod.class);
assertCompilationErrorOn(ClientWithWrongEnhancedMethod.class, "Object getRestTemplate();", result);
assertCompilationErrorOn(ClientWithWrongEnhancedMethod.class, "String getURL();", result);
assertCompilationErrorOn(ClientWithWrongEnhancedMethod.class, "String getRootURL();", result);
assertCompilationErrorOn(ClientWithWrongEnhancedMethod.class, "String getRootURL(String param);", result);
assertCompilationErrorOn(ClientWithWrongEnhancedMethod.class, "boolean setRootURL();", result);
assertCompilationErrorCount(5, result);
}AndroidAnnotations/androidannotations/src/test/java/org/androidannotations/rest/ClientWithWrongEnhancedMethod.java : @Rest(converters = { MappingJacksonHttpMessageConverter.class })
public interface ClientWithWrongEnhancedMethod {
// Correct
RestTemplate getTemplate();
String getRootUrl();
// Wrong
Object getRestTemplate();
String getURL();
String getRootURL();
String getRootURL(String param);
boolean setRootURL();
} |
Contributor
Author
|
I think I fixed all of these issues, let me know what you think |
Contributor
|
Just add a It directly shows that it compiles fine. The unit tests in AA core is just to check that validator is working fine and throws an error |
Contributor
Author
|
ok got it |
Contributor
|
Related to #599 |
Contributor
|
Thanks for the feature 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I'm doing this pull request right, first time. Anyway, added support for getRootUrl() to the Rest annotation.