Add maven wrapper for the library as well as for the maven example #1906
Conversation
|
I think we should not merge until we know what happened with #1905 |
@WonderCsabo I think we should not add copyright headers here but instead see if we can tell the license check to ignore those files? |
|
You are right. Please add these files to license check exclude list (it it easy). Another thing: make sure the unix |
|
You are right... Will check this evening |
|
I think you have to use a linux system for this. |
|
Looks like it is possible from windows too: http://blog.lesc.se/2011/11/how-to-change-file-premissions-in-git.html |
|
Cool. Just make sure it is committed with the correct permissions. |
WonderCsabo
left a comment
There was a problem hiding this comment.
One thing: Travis should be modified to use the wrapper command instead of calling the pre-installed Maven binary.
.travis.yml
Outdated
| - mvn -f AndroidAnnotations/pom.xml install -P travis | ||
| - mvn -f examples/maven/pom.xml install | ||
| - cd $TRAVIS_BUILD_DIR/AndroidAnnotations | ||
| - ./mvnw -f pom.xml install -P travis |
There was a problem hiding this comment.
-f pom.xml is not needed, as we are in the correct dir.
.travis.yml
Outdated
| - cd $TRAVIS_BUILD_DIR/AndroidAnnotations | ||
| - ./mvnw -f pom.xml install -P travis | ||
| - cd $TRAVIS_BUILD_DIR/examples/maven | ||
| - ./mvnw -f pom.xml install |
There was a problem hiding this comment.
-f pom.xml is not needed, as we are in the correct dir.
.travis.yml
Outdated
|
|
||
| after_success: | ||
| - if [[ $TRAVIS_REPO_SLUG == 'androidannotations/androidannotations' && $TRAVIS_BRANCH == 'develop' && $TRAVIS_PULL_REQUEST == 'false' && $TRAVIS_JDK_VERSION == 'oraclejdk7' ]]; then mvn -f AndroidAnnotations/pom.xml -DskipTests -Dquiet -s settings.xml deploy ; fi | ||
| - if [[ $TRAVIS_REPO_SLUG == 'androidannotations/androidannotations' && $TRAVIS_BRANCH == 'develop' && $TRAVIS_PULL_REQUEST == 'false' && $TRAVIS_JDK_VERSION == 'oraclejdk7' ]]; then cd $TRAVIS_BUILD_DIR/AndroidAnnotations && ./mvnw -f pom.xml -DskipTests -Dquiet -s settings.xml deploy ; fi |
There was a problem hiding this comment.
-f pom.xml is not needed, as we are in the correct dir.
|
@dodgex pls update the dev instructons on the wiki. |
|
Updated all usages of mvn with ./mvnw in wiki |
see #1894