This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Rename variables used for @Trace to avoid name collisions #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonderCsabo
suggested changes
Nov 23, 2016
| logEnterInvoke.arg(getEnterMessage(method, executableElement)); | ||
| thenBody.add(logEnterInvoke); | ||
| JVar startDeclaration = thenBody.decl(getCodeModel().LONG, "start", currentTimeInvoke); | ||
| JVar startDeclaration = thenBody.decl(getCodeModel().LONG, "traceStart_", currentTimeInvoke); |
Member
There was a problem hiding this comment.
I think we should use GENERATION_SUFFIX instead of hardcoding the underscore into every string.
- prefix variables with trace - postifx variables with underscore
eed6f8a to
ec27672
Compare
Member
Author
|
updated |
WonderCsabo
approved these changes
Nov 23, 2016
Member
Author
|
I think we should not merge until we know what happened with #1905 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1891