Please use Collections.unmodifiableMap(metaDataQualifiedNames) here.

Can you flatten this if?

if (nameAttribute == null && valueAttribute == null) {
  // malformed
} else if (nameAttribute != null) {
  // malformed with name
} else {
  // add it
}

Hi, I will make a review, and I will check directly the docs https://developer.android.com/guide/topics/manifest/meta-data-element.html, in General, I solved it to the needs of collecting the tags from within the manifest, and following the general structure:

<meta-data android:name="zoo" android:value="@string/kangaroo" />

I used also a Key-Value (a Map) to store and read all the elements. Checking in the docs, there's also a 3rd attribute that can be written in the Manifest, android:resource, never use it before to be honest, but in the general case should be included.

Maybe return a Map<String, SomeObject>, with SomeObject being a pair Value, Resource?.

On the other hands, I'm collecting the Metadata at the root level (Application), but it can be applied to:

    <activity>
    <activity-alias>
    <application>
    <provider>
    <receiver>
    <service>

In a general scenario, a reference to the parent tag should be also stored.

Any suggestion about this?
.

Checking now the code, I see that also a specific method is called to collect other tasks, I will do the same, to follow the same "rules". This was something I did like 1year ago, so probably the structure of the file was different for then, I will review this too.

Ah, about "flatting the if", now checking, I followed same structure for collecting other tags.. Do I flag them all?

private List<String> extractComponentNames(String applicationPackage, NodeList componentNodes) {
        List<String> componentQualifiedNames = new ArrayList<>();

        for (int i = 0; i < componentNodes.getLength(); i++) {
            Node activityNode = componentNodes.item(i);
            Node nameAttribute = activityNode.getAttributes().getNamedItem("android:name");

            String qualifiedName = manifestNameToValidQualifiedName(applicationPackage, nameAttribute);

            if (qualifiedName != null) {
                componentQualifiedNames.add(qualifiedName);
            } else {
                if (nameAttribute != null) {
                    LOGGER.warn("A class activity declared in the AndroidManifest.xml cannot be found in the compile path: [{}]", nameAttribute.getNodeValue());
                } else {
                    LOGGER.warn("The {} activity node in the AndroidManifest.xml has no android:name attribute", i);
                }
            }
        }
        return componentQualifiedNames;
    }

OOps, i missed the already existing ifs. In this case, i think you did the right thing, this way the code is consistent. We can refactor all ifs later.

i think documentElement.getElementsByTagName() will traverse this recursively and return all <meta-data> in components as well, doesn't it?

Yes it returns all the tags....