This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Stop validation when injectHelper invalidated the annotation (#1795) #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Lots of CS violatons. 😄 |
Member
|
Can you add a compile-time test case from the original issue? |
Member
Author
I grepped the if statement into the code and missed the spaces :/ |
Member
Author
|
i'll merge the commits - just used a free minute (hopefully) fix the CS violations from web :D |
This should fail to compile as an injection via method requires at least one parameter
Member
Author
|
@WonderCsabo updated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1795