support string arrays in defaultres #1626
Conversation
There was a problem hiding this comment.
We should handle the empty array here as well (I think it is possible to define an empty string array resource or not?)
There was a problem hiding this comment.
emtpy string array resource should not be a prolem. this code generates new HashSet<>(Arrays.asList(res.getStringArray(R.array.xxx))); if the resource is empty, the array is emtpy, the list is empty and the set is empty. also i think we have no way to access the number of items of a resource on compile time as the value might be diffrent for e.g. locales or screen sizes.
|
Can you extend @DefaultRes javadoc and explain which method return value should use which resource type? |
|
@WonderCsabo is the table ok? |
|
I think you are missing |
|
yeah you are right. |
…faultres Support string arrays in @DefaultRes
|
Nice, thanks. |
see #1625