This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Allow android.support{v7,v14} for @PreferenceXXX #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e790cfe to
335181e
Compare
Contributor
There was a problem hiding this comment.
This code :
holder.usingSupportV7Preference() ? getClasses().SUPPORT_V7_PREFERENCE : getClasses().PREFERENCE;is repeated at least three times in the code. Maybe we could add a method JClass getPreferenceClass() in HasPreferences.
Contributor
|
It is good, but has some duplicated code. |
335181e to
7d5e870
Compare
Member
Author
|
@yDelouis updated. |
yDelouis
added a commit
that referenced
this pull request
Sep 20, 2015
…gment
Allow android.support{v7,v14} for @PreferenceXXX
Contributor
|
Thanks ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535.