Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Conversation

@WonderCsabo
Copy link
Member

Fixes generic issues raised in #1402 and #1403.

@WonderCsabo WonderCsabo force-pushed the 1402_RestServiceGeneric branch 2 times, most recently from 89d2a82 to 655f84a Compare May 8, 2015 21:35
@WonderCsabo WonderCsabo force-pushed the 1402_RestServiceGeneric branch from 655f84a to 13f1a27 Compare June 4, 2015 14:40
@WonderCsabo
Copy link
Member Author

I also generified the return type of Fragment arg builder methods.

@WonderCsabo WonderCsabo force-pushed the 1402_RestServiceGeneric branch from 13f1a27 to ad58857 Compare June 4, 2015 14:43
@yDelouis
Copy link
Contributor

The generated class of GenericClient is :

public final class GenericClient_<T extends Object >
    implements GenericClient
{

    private String rootUrl;
    private RestTemplate restTemplate;

    public GenericClient_(Context context) {
        rootUrl = "";
        restTemplate = new RestTemplate();
        restTemplate.getMessageConverters().clear();
        restTemplate.getMessageConverters().add(new StringHttpMessageConverter());
    }
}

I think it should implement GenericClient<T> instead of GenericClient.

@WonderCsabo
Copy link
Member Author

@yDelouis you are right.

@WonderCsabo WonderCsabo force-pushed the 1402_RestServiceGeneric branch from ad58857 to 5b8b9d4 Compare June 10, 2015 16:07
@WonderCsabo
Copy link
Member Author

Fixed and rebased to develop.

@WonderCsabo
Copy link
Member Author

@yDelouis can we merge this?

@yDelouis
Copy link
Contributor

Is there some generic fragment, view and bean to see your changes ?

@WonderCsabo
Copy link
Member Author

SomeGenericViewGroup in the compile time test. There is no generic Fragment in the code base, i guess i should add one in the compile time test.

@WonderCsabo
Copy link
Member Author

There is a generic Fragment in #1445, so i do not want to add it here. Please copy it for your test.

yDelouis added a commit that referenced this pull request Jun 10, 2015
@yDelouis yDelouis merged commit 26b22a5 into androidannotations:develop Jun 10, 2015
@WonderCsabo WonderCsabo deleted the 1402_RestServiceGeneric branch June 10, 2015 21:42
@WonderCsabo WonderCsabo added this to the 4.0 milestone Jun 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants