This repository was archived by the owner on Feb 26, 2023. It is now read-only.
1235 do not use methodname as action #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
i decided to use |
Member
|
You forgot to update the test classes. |
Member
Author
|
the rebase broke the code. its fixed now |
Member
|
Thanks. Will merge to 4.0, but we may have to do several rebases until that, sorry. |
Member
Author
|
no problem. :) |
Member
|
Please rebase this PR so it can goo green. |
Member
Author
|
not sure if you got notified about the rebase... so just a smal ping @WonderCsabo :) |
Member
Author
|
a damn... i just realized that this PR is for 4.0. you just wanted the rebase to fix the build. /sorry |
Member
|
You do not have to be sorry at all. Thanks for notifying and for the rebase. |
yDelouis
added a commit
that referenced
this pull request
May 24, 2015
…tion 1235 do not use methodname as action
Contributor
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements issue #1235
based on PR #1234
do not merge before 4.0