smsgateway/domain_webhooks.go (1)

22-31: Keep the event list single-sourced.

allEventTypes and WebhookEventTypes() now require the same manual edits. Deriving the lookup map from one backing slice would avoid validation and enumeration drifting apart the next time a webhook event is added.

♻️ Proposed refactor

+var webhookEventTypes = []WebhookEvent{
+	WebhookEventSmsReceived,
+	WebhookEventSmsDataReceived,
+	WebhookEventSmsSent,
+	WebhookEventSmsDelivered,
+	WebhookEventSmsFailed,
+	WebhookEventSystemPing,
+	WebhookEventMmsReceived,
+	WebhookEventMmsDownloaded,
+}
+
 //nolint:gochecknoglobals // lookup table
-var allEventTypes = map[WebhookEvent]struct{}{
-	WebhookEventSmsReceived:     {},
-	WebhookEventSmsDataReceived: {},
-	WebhookEventSmsSent:         {},
-	WebhookEventSmsDelivered:    {},
-	WebhookEventSmsFailed:       {},
-	WebhookEventSystemPing:      {},
-	WebhookEventMmsReceived:     {},
-	WebhookEventMmsDownloaded:   {},
-}
+var allEventTypes = func() map[WebhookEvent]struct{} {
+	m := make(map[WebhookEvent]struct{}, len(webhookEventTypes))
+	for _, event := range webhookEventTypes {
+		m[event] = struct{}{}
+	}
+	return m
+}()
 
 // WebhookEventTypes returns a slice of all supported webhook event types.
 func WebhookEventTypes() []WebhookEvent {
-	return []WebhookEvent{
-		WebhookEventSmsReceived,
-		WebhookEventSmsDataReceived,
-		WebhookEventSmsSent,
-		WebhookEventSmsDelivered,
-		WebhookEventSmsFailed,
-		WebhookEventSystemPing,
-		WebhookEventMmsReceived,
-		WebhookEventMmsDownloaded,
-	}
+	return append([]WebhookEvent(nil), webhookEventTypes...)
 }

Also applies to: 34-44

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@smsgateway/domain_webhooks.go` around lines 22 - 31, The event list is
duplicated between the allEventTypes map and WebhookEventTypes(), causing drift;
consolidate to a single source (e.g., define a slice variable like
allEventTypeList or webhookEventList containing WebhookEvent values) and derive
both the lookup map (allEventTypes) and the WebhookEventTypes() return from that
single slice (build the map in init or lazily from the slice). Update references
to use the new slice name and remove the duplicated literal lists (also apply
the same change for the similar block referenced at lines 34-44).

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes