Clean architecture experiment [DO NOT MERGE]#1277
Closed
dturner wants to merge 5 commits into
Closed
Conversation
Change-Id: I7b019a186e6fa69f81f053e2bd9379d906a72dfd
Change-Id: Ibe3e115e7618505a51fe34c8ebbf80691d344ad5
Change-Id: If2234d2978d108c199b06484a8c58a11d2e0e4f1
Change-Id: Id859d9d1f33b16436390a0960dffa9bcf81fada8
Change-Id: Icd4d875f44525a1e6f92f52ec71da7f6482aba98
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What have I done and why?
Following on from this discussion, I have refactored the codebase to use clean architecture. Specifically I have moved the
:core:datarepository interfaces into the:core:domainmodule.I am not advocating for this approach. This is just an experiment to see how difficult it is to refactor the codebase. Took about an hour.