Skip to content

alignas(xxx) is repeated  #456

@nickhuang99

Description

@nickhuang99

Taking tests/AlignAsTest.cpp as an example, the expression "alignas(128)" is repeated because it is not treated as part of global variable. To me, alignas is more or less like a sort of "assert" statement. Therefore "GetSourceRangeAfterSemi" does NOT include "alignas(128)" at all.

issue description:
original: alignas(128) char alignedArray[128];
transformed: alignas(128) alignas(128) char alignedArray[128];

suggested fix:


diff --git a/GlobalVariableHandler.cpp b/GlobalVariableHandler.cpp
index 6d3547b..49823f8 100644
--- a/GlobalVariableHandler.cpp
+++ b/GlobalVariableHandler.cpp
@@ -94,7 +94,7 @@ void GlobalVariableHandler::run(const MatchFinder::MatchResult& result)
                                  outputFormatHelper.GetString());
 
         } else {
-            mRewrite.ReplaceText(sr, outputFormatHelper.GetString());
+            //mRewrite.ReplaceText(sr, outputFormatHelper.GetString());
         }
     }
 }

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions